Skip to content

Commit

Permalink
Richaudience Bid Adapter): change url tracking (#10963)
Browse files Browse the repository at this point in the history
* RichaudienceBidAdapter add function onTimeout

* Add unit test

* revert: Revert changes in integrationExamples/creative.html

* fix: Remove useless package in richaudiences test module

* Change referer with host

* Fix(RichaudienceBidAdapter): Change url tracking

* deploy

* change test

---------

Co-authored-by: Sergi Gimenez <sergi.gimenez@exte.com>
  • Loading branch information
richaudience and Sergi Gimenez authored Jan 18, 2024
1 parent 34e6192 commit faec96e
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion modules/contxtfulRtdProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ function getReceptivity() {
* @param { [String] } adUnits
* @param {*} _config
* @param {*} _userConsent
* @return {{ code: { ReceptivityState: String } }}
* @return {{ code: { ReceptivityState: String } }}
*/
function getTargetingData(adUnits, _config, _userConsent) {
logInfo(MODULE, 'getTargetingData');
Expand Down
46 changes: 23 additions & 23 deletions modules/dsp_genieeBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,21 @@ export const spec = {
code: BIDDER_CODE,
supportedMediaTypes: [BANNER],
/**
* Determines whether or not the given bid request is valid.
*
* @param {BidRequest} - The bid params to validate.
* @return boolean True if this is a valid bid, and false otherwise.
*/
* Determines whether or not the given bid request is valid.
*
* @param {BidRequest} - The bid params to validate.
* @return boolean True if this is a valid bid, and false otherwise.
*/
isBidRequestValid: function (_) {
return true;
},
/**
* Make a server request from the list of BidRequests.
*
* @param {validBidRequests[]} - an array of bids
* @param {bidderRequest} - the master bidRequest object
* @return ServerRequest Info describing the request to the server.
*/
* Make a server request from the list of BidRequests.
*
* @param {validBidRequests[]} - an array of bids
* @param {bidderRequest} - the master bidRequest object
* @return ServerRequest Info describing the request to the server.
*/
buildRequests: function (validBidRequests, bidderRequest) {
if (deepAccess(bidderRequest, 'gdprConsent.gdprApplies') || // gdpr
USPConsent(bidderRequest.uspConsent) || // usp
Expand Down Expand Up @@ -84,12 +84,12 @@ export const spec = {
};
},
/**
* Unpack the response from the server into a list of bids.
*
* @param {ServerResponse} serverResponse A successful response from the server.
* @param {BidRequest} bidRequest - the master bidRequest object
* @return {bids} - An array of bids which were nested inside the server.
*/
* Unpack the response from the server into a list of bids.
*
* @param {ServerResponse} serverResponse A successful response from the server.
* @param {BidRequest} bidRequest - the master bidRequest object
* @return {bids} - An array of bids which were nested inside the server.
*/
interpretResponse: function (serverResponse, bidRequest) {
if (!serverResponse.body) { // empty response (no bids)
return [];
Expand All @@ -99,12 +99,12 @@ export const spec = {
},

/**
* Register the user sync pixels which should be dropped after the auction.
*
* @param {SyncOptions} syncOptions Which user syncs are allowed?
* @param {ServerResponse[]} serverResponses List of server's responses.
* @return {UserSync[]} The user syncs which should be dropped.
*/
* Register the user sync pixels which should be dropped after the auction.
*
* @param {SyncOptions} syncOptions Which user syncs are allowed?
* @param {ServerResponse[]} serverResponses List of server's responses.
* @return {UserSync[]} The user syncs which should be dropped.
*/
getUserSyncs: function (syncOptions, serverResponses, gdprConsent, uspConsent) {
const syncs = [];
// gdpr & usp
Expand Down
2 changes: 1 addition & 1 deletion modules/richaudienceBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ function raiGetTimeoutURL(data) {
url = url.replace('[timeout_publisher]', timeout)
url = url.replace('[placement_hash]', params[0].pid)
if (REFERER != null) {
url = url.replace('[domain]', REFERER)
url = url.replace('[domain]', document.location.host)
}
return url
}
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/spec/modules/richaudienceBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@ describe('Richaudience adapter tests', function () {
it('should send timeout', function () {
spec.onTimeout(DEFAULT_PARAMS_VIDEO_TIMEOUT);
expect(utils.triggerPixel.called).to.equal(true);
expect(utils.triggerPixel.firstCall.args[0]).to.equal('https://s.richaudience.com/err/?ec=6&ev=3000&pla=ADb1f40rmi&int=PREBID&pltfm=&node=&dm=http%3A%2F%2Fdomain.com');
expect(utils.triggerPixel.firstCall.args[0]).to.equal('https://s.richaudience.com/err/?ec=6&ev=3000&pla=ADb1f40rmi&int=PREBID&pltfm=&node=&dm=localhost:9876');
});
});

Expand Down

0 comments on commit faec96e

Please sign in to comment.