Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplelift bid adapter: overrides publisher selections #10407

Closed
patmmccann opened this issue Aug 29, 2023 · 0 comments · Fixed by #10408
Closed

Triplelift bid adapter: overrides publisher selections #10407

patmmccann opened this issue Aug 29, 2023 · 0 comments · Fixed by #10408
Assignees

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Aug 29, 2023

Type of issue

Bug

Description

With https://prebid.org/prebid-5-0-release/ and the adoption of #5237 ; we mandated bid adapters take the openRTB fields publishers set in mediatypes.video

Expected results

Setting video.placement is passed to triplelift's openrtb payload

Actual results

Triplelift overrides the publisher logic with https://github.com/prebid/Prebid.js/blob/e78e4b89df78dcb0578bd74be33d6c2b92e41f81/modules/tripleliftBidAdapter.js#L242C2-L242C57

If a publisher wants to set context in prebid to indicate to prebid there is a player and not a gpt unit requiring a renderer, triplelift should not override their selection of video.placement placing them in jeopardy of IVT enforcement by DSPs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant