dfpAdServerVideo auto include the adpod module on build, potential size saving?

[spormeon]

question: does the video module auto include the adpod module on build, as I'm seeing the adpod module in my build but i'm not including it directly. If so, it would be good to be able to drop the adpod include, if possible, if dont need it, saves some 24kib by the looks of it

includes with videojs, not checked with jwplayer

not in modules:

but in build:

[spormeon]

it seems to be the "dfpAdServerVideo" module thats adding the "adpod" module as well

but then appnexus is adding "categoryTranslationMapping.js" with its adapter:

no clue if its even possible to "drop" these, if someone doesnt need/ use them, but seems like a way to save some "size"

[dgirardi]

dfpAdServerVideo and freeWheelAdserverVideo are set up as adpod submodules. adlooxAdServerVideo (the youngest) is not. I think this is probably a historical accident, to me it looks like in the beginning adpod was meant to be what outstream video is now.

The fix is unfortunately also a breaking change - marking this for 9.0

Appnexus is a different matter - categoryTranslationMapping.js is the library, not the module, and expected.

[patmmccann]

#4048 (comment) references this interestingly

[dgirardi]

proposal: move adpod logic in a new "dfpAdpodServerVideo"