Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

referenced 'registerAdserver' but it was never created #4048

Closed
ghost opened this issue Aug 1, 2019 · 10 comments
Closed

referenced 'registerAdserver' but it was never created #4048

ghost opened this issue Aug 1, 2019 · 10 comments
Assignees
Labels
pinned won't be closed by stalebot

Comments

@ghost
Copy link

ghost commented Aug 1, 2019

Type of issue

bug/question

Description

When I add a dfpAdServerVideo to my modules I get Warning in the console. I don't use this module in my webpage, it is only included into Prebid.js library.
blad-prebid

Steps to reproduce

  1. Use: gulp serve --modules=consentManagement,rubiconBidAdapter,adomikAnalyticsAdapter,dfpAdServerVideo
  2. On the site with active Prebid library above described Warning is present.

Expected results

My questions are:
Is it a bug?
How can I handle this issue?

Platform details

I tested Prebid.js version 2.26.0, 2.25.0 only.

@jaiminpanchal27 jaiminpanchal27 self-assigned this Aug 1, 2019
@jaiminpanchal27
Copy link
Collaborator

@aszydlo Thanks for reporting this, I will check and get back to you.

@spormeon
Copy link

spormeon commented Aug 2, 2019

+1, i get this as well and no idea if its something to worry about?

@snapwich
Copy link
Collaborator

snapwich commented Aug 2, 2019

Just FYI, the warning is because the registerAdserver hook is defined in the categoryTranslation module (which isn't in your build) but is referenced in other modules such as the dfpAdServerVideo that are in your build.

@stale
Copy link

stale bot commented Aug 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 16, 2019
@jsnellbaker jsnellbaker added pinned won't be closed by stalebot and removed stale labels Aug 20, 2019
@tandalevaibhav
Copy link

tandalevaibhav commented Oct 1, 2019

I am using Prebid 2.34.0
Getting the same warning as well as one other:-
"fun-hooks: referenced 'registerAdserver' but it was never created"
"fun-hooks: referenced 'adpod' but it was never created"
Is there anything I should worry about?

@jaiminpanchal27
Copy link
Collaborator

jaiminpanchal27 commented Oct 2, 2019

@tandalevaibhav We have verified this and not a bug. This warning appears when an optional module is adds a hook on hook point which does not exist.

In this case, dfpAdserverVideo here is trying to add hook on categoryTranslation here but as categoryTranslation module is not included in build this warning is logged.

We are trying to fix this unwanted warning message

@gglas
Copy link

gglas commented Feb 8, 2021

assigning @robertrmartinez

patmmccann added a commit to patmmccann/Prebid.js that referenced this issue Mar 23, 2021
This would add a requirement that getConfig('brandCategoryTranslation.translationFile') exists for the hook to the translation module to occur, solving prebid#4048

This is technically a breaking change, as publishers that want this hook to occur from dfp would have to define this config, however I think there are zero affected pubs, because the default translation file is for freewheel, so the it wouldn't make any sense not to have the config.
@gglas
Copy link

gglas commented May 10, 2021

@patmmccann do the referenced PRs just relate or do the address the issue? If they don't address, @robertrmartinez quick ping reminder on this one!

@patmmccann
Copy link
Collaborator

#6464 fixes the issue, awaiting merge

@gglas
Copy link

gglas commented Jul 19, 2021

merged and fixed in 5.0, closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned won't be closed by stalebot
Projects
None yet
Development

No branches or pull requests

8 participants