-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
referenced 'registerAdserver' but it was never created #4048
Comments
@aszydlo Thanks for reporting this, I will check and get back to you. |
+1, i get this as well and no idea if its something to worry about? |
Just FYI, the warning is because the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I am using Prebid 2.34.0 |
@tandalevaibhav We have verified this and not a bug. This warning appears when an optional module is adds a hook on hook point which does not exist. In this case, dfpAdserverVideo here is trying to add hook on categoryTranslation here but as categoryTranslation module is not included in build this warning is logged. We are trying to fix this unwanted warning message |
assigning @robertrmartinez |
This would add a requirement that getConfig('brandCategoryTranslation.translationFile') exists for the hook to the translation module to occur, solving prebid#4048 This is technically a breaking change, as publishers that want this hook to occur from dfp would have to define this config, however I think there are zero affected pubs, because the default translation file is for freewheel, so the it wouldn't make any sense not to have the config.
@patmmccann do the referenced PRs just relate or do the address the issue? If they don't address, @robertrmartinez quick ping reminder on this one! |
#6464 fixes the issue, awaiting merge |
merged and fixed in 5.0, closing issue |
Type of issue
bug/question
Description
When I add a dfpAdServerVideo to my modules I get
![blad-prebid](https://user-images.githubusercontent.com/38684131/62294759-ff587b80-b46b-11e9-9514-f5bdf07f0abb.jpg)
Warning
in the console. I don't use this module in my webpage, it is only included into Prebid.js library.Steps to reproduce
Warning
is present.Expected results
My questions are:
Is it a bug?
How can I handle this issue?
Platform details
I tested Prebid.js version 2.26.0, 2.25.0 only.
The text was updated successfully, but these errors were encountered: