Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New activity control: load external script #11010

Closed
patmmccann opened this issue Jan 30, 2024 · 0 comments · Fixed by #12207
Closed

New activity control: load external script #11010

patmmccann opened this issue Jan 30, 2024 · 0 comments · Fixed by #12207
Assignees
@mkomorski

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jan 30, 2024 •
edited
Loading

Type of issue

Feature Req

Description

loadExternalScript in adLoader.js should have an activity control surrounding it.
mkomorski pushed a commit that referenced this issue Sep 5, 2024
#11010 New activity control - load external script
6aa4e87
@mkomorski mkomorski mentioned this issue Sep 5, 2024
Merged
10 tasks
@patmmccann patmmccann mentioned this issue Oct 8, 2024
Closed
@patmmccann patmmccann linked a pull request Oct 8, 2024 that will close this issue
Core: New activity control - load external script #12207
Merged
10 tasks
ChrisHuie pushed a commit that referenced this issue Oct 10, 2024
@mkomorski @dgirardi
Core: New activity control - load external script (#12207)
9965e0e 
* #11010 New activity control - load external script

* improvements

* adding module type to load external script

* update loadScript stub

* Swap moduleType/moduleCode for consistency

---------

Co-authored-by: Marcin Komorski <marcinkomorski@marcins-mbp.home>
Co-authored-by: Marcin Komorski <marcinkomorski@Marcins-MacBook-Pro.local>
Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkomorski mkomorski

Labels
None yet
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core: New activity control - load external script prebid/Prebid.js
2 participants
@patmmccann @mkomorski