Enforcement: stop importing events system in bidders

[patmmccann]

Type of issue

feature request

Description

to prevent the need for any adaptor to import the events system, we should expand the scope of onBidderError to more than just network errors, potentially to support use cases such as failing to understand the response or something of this nature.

The following bidders currently import events

Prebid.js/modules/holidBidAdapter.js

Line 8 in 9270339

import * as events from '../src/events.js';

fyi @kdesput please convert to use onBidWon

We should add the linter rule

[dgirardi]

Need to define what the extended scope would be. Bidders have control over their code and can already do what they wish with errors they generate. Looking at those adapters:

• nextMillennium: their use of events is not related to errors - it looks like plain analytics
• holid: not related to errors, it should be using onBidWon

This leaves ix. they intend to capture error logs and rendering failures related to their adapter. I don't think their approach works, but besides that:

• an error message should always come together with an error. It makes more sense to look at the error - we could provide them an onException handler, but they could also just wrap their logic a try/catch.
• rendering failures are, to the best of my knowledge, not bidder failures. I don't think a bidder can cause them.

[patmmccann]

#11141 partially fixes

[patmmccann]

docs: prebid/prebid.github.io#5189

[patmmccann]

Summary of to do: fix holid adapter, add a linting rule for bidders not to import events using a no-restricted-imports rule on es lint

[dgirardi]

Also add linting rule to exclude bidders from importing adLoader