If bids for 2 units requested and prebid-server responds with one bid, auction doesn't end until timeout

[dmitriyshashkin]

Type of issue

Bug

Description

If there are less bids from prebid-server than there are units for which bids were requested, prebid-server response would look something like the following:

{
        "tid": "0b54cd48-934f-40ef-bd36-f1e6a9a7ba4b",
        "status": "OK",
        "bidder_status": [{
            "bidder": "rubicon",
            "response_time_ms": 150,
            "num_bids": 1
        }],
        "bids": [{
            "bid_id": "2c4a7ec8d3c126",
            "code": "ad_cs_9493688_728_90",
            "creative_id": "4227344",
            "bidder": "rubicon",
            "price": 0.226596,
            "adm": "%ad code here%",
            "width": 728,
            "height": 90
        }]
}

There is no no-bid flag and there is an information about one bid. Prebid server adapter will pass information about this bid to bid manager, but it won't pass information about the lack of bids for other units. And inside bid manager, the check that compares number of requests sent and number of responses received will determine that there are less responses than there were requests. So bid manager will keep waiting for additional responses, even though there won't be any. The auction will end only upon timeout.

Steps to reproduce

Setup rubicon or pubmatic to work through prebid-server. Send requests for two ad units. Prebid-server must return one bid only.

Expected results

Two responses are passed to bid manager. One with STATUS.GOOD and another with STATUS.NO_BID. Bid manager ends the bidding and calls callback function.

Actual results

One STATUS.GOOD response is passed to bid manager. Bid manager keeps waiting for the second response until timeout.

Platform details

Prebid v0.24-pre

Other information

Similar to #1196