Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoBid response from prebid server has no adUnitCode, addBitResponse discards it #1196

Closed
dmitriyshashkin opened this issue May 11, 2017 · 1 comment · Fixed by #1204
Closed

Comments

@dmitriyshashkin
Copy link
Contributor

Type of issue

Bug

Description

NoBid response from prebid server has no adUnitCode, addBitResponse discards it, auction doesn't stop until timeout

Steps to reproduce

Initialize auction with pubmatic or rubicon working through prebidServer. Receive no-bid response

Expected results

response has ad unit code, addBitResponse accepts it, when other bids arrive, auction is complete

Actual results

response has not ad unit code, addBitResponse produces warning: "No adUnitCode supplied to addBidResponse, response discarded", auction doesn't end until timeout

Platform details

0.24.0-pre
node v6.9.5
Fedora 25
Browser Chrome 58

Other information

Prebid server response:

{
"tid": "44b005c6-10d6-4aa5-958a-d750f7dc6762",
"status": "OK",
"bidder_status": [{
"bidder": "pubmatic",
"response_time_ms": 35,
"no_bid": true
}, {
"bidder": "rubicon",
"response_time_ms": 213,
"num_bids": 1
}, {
"bidder": "indexExchange",
"ad_unit": "ad_cs_9493688_728_90",
"response_time_ms": 91,
"no_bid": true
}],
"bids": [{
"bid_id": "2d379517db8e53",
"code": "ad_cs_9493688_728_90",
"creative_id": "4320530",
"bidder": "rubicon",
"price": 0,
"adm": "creative here");",
"width": 728,
"height": 90
}]
}

@mkendall07
Copy link
Member

Thanks for the report. Will address in a future release.

dmitriyshashkin added a commit to dmitriyshashkin/Prebid.js that referenced this issue May 16, 2017
mkendall07 pushed a commit that referenced this issue May 19, 2017
…every adUnit requested (#1204)

* No bid response has no ad unit, create bid response for every ad unit requested

To fix #1196

* Test to cover cases when response has no bids

* Pass through the bid object to link request and response

* Some fixes to support new linting

* Populated wrong field

* Generate status NO_BID response if server requested usersync
dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
…every adUnit requested (prebid#1204)

* No bid response has no ad unit, create bid response for every ad unit requested

To fix prebid#1196

* Test to cover cases when response has no bids

* Pass through the bid object to link request and response

* Some fixes to support new linting

* Populated wrong field

* Generate status NO_BID response if server requested usersync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants