Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildVideoUrl doesn't respect enableSendAllBids config? #1914

Closed
harbinha opened this issue Dec 4, 2017 · 2 comments · Fixed by #2826
Closed

buildVideoUrl doesn't respect enableSendAllBids config? #1914

harbinha opened this issue Dec 4, 2017 · 2 comments · Fixed by #2826
Assignees
Labels

Comments

@harbinha
Copy link

harbinha commented Dec 4, 2017

Type of issue

Help wanted

Description

I've tried setting both enableSendAllBids: true in setConfig as well as calling pbjs.enableSendAllBids(); and I've ensure enableSendAllBids is true in the global pbjs.getConfig() object, but I'm still not getting the hb_pb_{ADAPTER} keys to be returned from pbjs.adServers.dfp.buildVideoUrl. Is this expected, or am I missing something?

What I'm getting back includes:
hb_bidder=appnexusAst&hb_pb=19.90 for example;
but our targeting in DFP is set up for hb_pb_{ADAPTER}. I can prepend these manually, but just seeing if I'm missing something else, since the documentation doesn't mention using enableSendAllBids for video that I can see.

Steps to reproduce

pbjs.enableSendAllBids(); or

pbjs.setConfig({
    enableSendAllBids: true,
    usePrebidCache: true
});

retrieve bids
let foo = pbjs.adServers.dfp.buildVideoUrl({ // dfp params here })
foo will not contain hb_pb_{ADAPTER} parameters

Expected results

hb_pb_{ADAPTER} parameters included in string returned from buildVideoUrl

Actual results

hb_pb_{ADAPTER} parameters are not included in string returned from buildVideoUrl

Platform details

prebid v0.33.0
Mac OS X 10.11.6
Chrome 62.0.3202.94

@mkendall07
Copy link
Member

sounds like a bug. Thanks for letting us know. We will address soon or if you feel like submitting a fix that would be awesome.

@mkendall07 mkendall07 added the bug label Dec 12, 2017
@stale
Copy link

stale bot commented Mar 9, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants