Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure enableSendAllBids targeting data is used in buildVideoUrl function #2826

Merged
merged 1 commit into from
Jul 10, 2018
Merged

ensure enableSendAllBids targeting data is used in buildVideoUrl function #2826

merged 1 commit into from
Jul 10, 2018

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Fixes #1914

@jsnellbaker jsnellbaker changed the title include targeting data in buildVideoUrl function ensure enableSendAllBids targeting data is used in buildVideoUrl function Jul 9, 2018
jaiminpanchal27
jaiminpanchal27 approved these changes Jul 9, 2018
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Jul 10, 2018
snapwich
snapwich approved these changes Jul 10, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit e087cd2 into master Jul 10, 2018
@mkendall07 mkendall07 deleted the video_getAllBids_fix branch August 17, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

@snapwich snapwich snapwich approved these changes

@mkendall07 mkendall07 Awaiting requested review from mkendall07

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
LGTM needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buildVideoUrl doesn't respect enableSendAllBids config?
3 participants
@jsnellbaker @snapwich @jaiminpanchal27