Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our version of gulp-webdriver depends on github dependency which sometimes fails #2138

Closed
snapwich opened this issue Feb 12, 2018 · 6 comments

Comments

@snapwich
Copy link
Collaborator

Type of issue

bug

Description

The version of gulp-webdriver we have in our package.json depends on the master branch of a github repo which can cause build failures when accessing github or other issues since its dependency is not fixed to a version (master is always the latest).

I don't see it being referenced in this project other than in package.json. Can it be removed? If not, can we update to a later version that removes that dependency?

@stale
Copy link

stale bot commented Mar 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 7, 2018
@stale stale bot closed this as completed Mar 14, 2018
@snapwich
Copy link
Collaborator Author

This issue is still causing occasional fails in our internal build process. Reopening.

@snapwich snapwich reopened this Apr 12, 2018
@stale
Copy link

stale bot commented Apr 26, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 26, 2018
@snapwich
Copy link
Collaborator Author

still an issue

@stale stale bot removed the stale label Apr 30, 2018
@mkendall07 mkendall07 added bug and removed wontfix labels Apr 30, 2018
@thewizarodofoz
Copy link
Contributor

Just to make sure - this was addressed in #2863, right?

@jsnellbaker
Copy link
Collaborator

@snapwich This should have been addressed per the PR that @thewizarodofoz noted.

Please review and close if we're good at this point. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants