update several packages to address vulnerability warnings #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we are not using |
|
Thanks for the heads-up. I pushed a commit to remove these packages from the files. |
mkendall07
approved these changes
Jul 18, 2018
jsnellbaker
changed the title
jsnellbaker
added
needs 2nd review
jaiminpanchal27
approved these changes
Jul 19, 2018
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* update coveralls and webdriver pacakges * remove gulp-webdriver and webdriverio packages * update additional packages to fix other vulnerabilities
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* update coveralls and webdriver pacakges * remove gulp-webdriver and webdriverio packages * update additional packages to fix other vulnerabilities
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* update coveralls and webdriver pacakges * remove gulp-webdriver and webdriverio packages * update additional packages to fix other vulnerabilities
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* update coveralls and webdriver pacakges * remove gulp-webdriver and webdriverio packages * update additional packages to fix other vulnerabilities
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* update coveralls and webdriver pacakges * remove gulp-webdriver and webdriverio packages * update additional packages to fix other vulnerabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update the
coveralls,gulp-connect,nightwatchpackages and remove thegulp-webdriverpackage as it isn't needed.The update to
coverallsis to partially address an issue with a devDependency package chain that uses vulnerable version ofhoek. Details on the vulnerability can be found here. These newer packages use a different chain that doesn't installhoek.The updates to
gulp-connectandnightwatchwere to address other vulnerability warnings that were seen when runningnpm install. Details of the warnings can be seen withnpm audit.Note
The latest version of Karma (2.0.4) we use still has a dependency chain that uses the vulnerable version of
hoek, so there's nothing to be done to fully address the issue at this time.