Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserId module references usersync and not userSync #3818

Closed
ETNOL opened this issue May 10, 2019 · 2 comments
Closed

UserId module references usersync and not userSync #3818

ETNOL opened this issue May 10, 2019 · 2 comments
Assignees

Comments

@ETNOL
Copy link
Contributor

ETNOL commented May 10, 2019

@idettman Should this be using userSync and not usersync?

Originally posted by @ETNOL in #3424 (comment)

@bretg
Copy link
Collaborator

bretg commented May 14, 2019

Wow - that's an unfortunate one. Hard to believe no one caught that in several reviews. Ultimately it's my fault because that's how the original issue specified it. #3046

At least the documentation is aligned with the code.

@idettman - please modify the code to look for both usersync and userSync, explaining in a comment that a future major release will deprecate the lowercase version.

@bretg
Copy link
Collaborator

bretg commented May 20, 2019

Confirmed that this is part of PR 3831. Closing this issue.

@bretg bretg closed this as completed May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants