Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User ID Module #3424

Merged
merged 185 commits into from
Apr 4, 2019
Merged

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Jan 7, 2019

User ID Module

Type of change

  • Feature

Description of change

This module adds a User ID module, which currently includes submodules for Unified ID and Pub Common ID.

Submodule Configuration

Each submodule can configure how it stores user id data to the the browser.

type: sets the browser storage API used to store the user data. The supported types are html5, or cookie

  1. html5 uses window.localStorage
  2. cookie uses document.cookies

expires: days to expire to locally stored values

name: the name of the key used to store user data

Example

// Activate unifiedId and pubCommonId user data values to be passed to bid adapters
pbjs.setConfig({
  usersync: {
    userIds: [{
      name: "unifiedId",
      params: {
        partner: "PARTNER_ID",
        url: "http://match.adsrvr.org/track/rid?ttd_pid=prebid&fmt=json"
      },
      storage: {
        type: "html5",
        name: "unifiedid",
        expires: 60
      }
    }, {
      name: "pubCommonId",
      storage: {
        type: "cookie",
        name: "pubcid",
        expires: 30
      }
    }],
    syncDelay: 5000
  }
});

Isaac Dettman and others added 30 commits December 10, 2018 11:52
…ow to handle both 'value' and 'storage' existing in config
… add test for one storage type active with only one module configured to use that type
…ook due to necessary use of prebid global object affecting following tests
…ows watching the first element added to add the bid request hook
…invalid config storage type, revised commenting
@bretg
Copy link
Collaborator

bretg commented Apr 4, 2019

@pycnvr , @jsnellbaker , @snapwich - hoping to release this next week with 2.10. I believe Isaac's updated it with the inspection requests except for some features that I propose we hash out in a separate thread.

@pycnvr
Copy link
Collaborator

pycnvr commented Apr 4, 2019

Looks good.

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit eeddc24 into prebid:master Apr 4, 2019
@idettman idettman added the LGTM label Apr 4, 2019
@ETNOL
Copy link
Contributor

ETNOL commented Apr 12, 2019

@idettman Should this be using userSync and not usersync?

@idettman idettman deleted the add-universal-id-module branch June 5, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants