Kargo Bidder tries to define _sessionId in frozen spec object.

[betancourtl]

Type of issue

Bug

Description

Looks like kargoBidAdapter is crashing when fetching bids because it tries to update the spec object. The spec object gets frozen by the registerBidder() fn.

I tracked that fn call in the kargoBidAdapter and it lead me here:

Prebid.js/modules/kargoBidAdapter.js

Lines 186 to 192 in 2be5cc7

	_getSessionId() {
	if (!spec._sessionId) {
	spec._sessionId = spec._generateRandomUuid();
	}
	return spec._sessionId;
	},

the spec object then gets passed here where it gets frozen.

Prebid.js/src/adapters/bidderFactory.js

Lines 166 to 170 in 2be5cc7

	return Object.assign(new Adapter(spec.code), {
	getSpec: function() {
	return Object.freeze(spec);
	},
	registerSyncs,

From MDN

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze

A frozen object can no longer be changed; freezing an object prevents new properties from being added to it, existing properties from being removed, prevents changing the enumerability, configurability, or writability of existing properties, and prevents the values of existing properties from being changed. In addition, freezing an object also prevents its prototype from being changed. freeze() returns the same object that was passed in.

Steps to reproduce

Try to request bids using kargoBidAdapter on a page and use the debug query param
pbjs_debug=true

Expected results

Expect the bidder not to crash.

Actual results

bidder crashes.

[betancourtl]

Looks like it was fixed by #3998

[bretg]

Yup fixed with #3998