Kargo Adapter: fix extensible error #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebid.js into master-rubicon-clean
# Conflicts: # modules/advangelistsBidAdapter.js # test/spec/modules/advangelistsBidAdapter_spec.js
…ter-remote-updated
…into kargo-adapter-fix-extensible-sessionid
|
@samuelhorwitz - FYI |
|
Ah good catch. Thanks |
|
That newest change will likely break tests which rely on that variable being accessible |
harpere
approved these changes
Jul 16, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * add '_sessionId' to the object literal for spec * removed error merge * replaced obj property with sibling variable * updated test for changes to sessionId
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * add '_sessionId' to the object literal for spec * removed error merge * replaced obj property with sibling variable * updated test for changes to sessionId
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * add '_sessionId' to the object literal for spec * removed error merge * replaced obj property with sibling variable * updated test for changes to sessionId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Kargo Bid Adapter bugfix for non-extensible error on
mobile/tabletdevicetype.Issue was introduced by: https://github.com/prebid/Prebid.js/pull/3897/files.
Cause seems to be the kargo adapter spec object properties are being changed to readOnly and
Object.preventExtensions(o)is also called;Error output (chrome debug tools with IPhoneX mode):