Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audience Network 3.x support #4694

Closed
josephtyler opened this issue Jan 6, 2020 · 11 comments
Closed

Audience Network 3.x support #4694

josephtyler opened this issue Jan 6, 2020 · 11 comments
Assignees

Comments

@josephtyler
Copy link
Contributor

Does anyone know if the Audience Network module will be included in Prebid 3.x anytime soon?

Type of issue

Question

Description

Audience Network 3.x support.

Steps to reproduce

Test page

Expected results

Actual results

Platform details

Other information

@jsnellbaker
Copy link
Collaborator

Hi @lovell
I saw your name tagged on the majority of commits for the audience network bid adapter. When you get a chance, can you comment here on this question?

Thanks!

@lovell
Copy link
Contributor

lovell commented Jan 8, 2020

Yes, support for Audience Network in Prebid.js v3 is currently under development.

@khatibda
Copy link
Contributor

khatibda commented Jan 8, 2020

@lovell any sense for rough ETA? we are debating whether to wait for that adapter before going live with the new prebid, or just proceed and temporarily pause you. if your adapter is coming in a week or 2 we'll wait, if you think timing is longer than that we're likely just to move ahead. any guidance would be much appreciated!

@lovell
Copy link
Contributor

lovell commented Jan 9, 2020

I guess this will partly depend on the Prebid.js review, merge and release process, especially as there appears to be a higher than usual number of open PRs to migrate other adapters.

If you're already building your own Prebid.js bundle to include specific adapters then I might be able to provide a patch file to allow you to do some preliminary testing and therefore help you make a decision.

@khatibda
Copy link
Contributor

khatibda commented Jan 9, 2020

@lovell oh a patch file would be terrific. (yes we roll our own bundle). thanks in advance! let us know if you need any more info, we're standing by.

separately, if you have an official PR you can share once ready, we will gladly advocate for its priority in the review queue. this is a high priority adapter!

@jsnellbaker
Copy link
Collaborator

@lovell Please feel free to tag me on the PR when it gets created; I'll keep an eye out and help with the review process.

@jsnellbaker jsnellbaker self-assigned this Jan 9, 2020
@khatibda
Copy link
Contributor

@lovell just checking in, any ETA on the PR or the patch file? thanks in advance, you guys are kind of a big deal!

@bretg bretg assigned robertrmartinez and unassigned jsnellbaker Jan 22, 2020
@khatibda
Copy link
Contributor

@lovell @bretg hi - any status update on this? i am confident this is holding up a bunch of 3.x upgrades.

@robertrmartinez
Copy link
Collaborator

@khatibda

Hi, I am making the changes to get the adapter into the master branch now.

Hoping to get it done soon and reviewed and merged.

@robertrmartinez
Copy link
Collaborator

@khatibda @bretg @jsnellbaker @lovell

I have made a PR which addresses this.

I think I fixed (The only issue) which was the usage of getTopWindowUrl

#4769

@bretg
Copy link
Collaborator

bretg commented Jan 23, 2020

Thanks @robertrmartinez

@bretg bretg closed this as completed Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants