Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the audience network adapter to be 3.x compliant #4769

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

robertrmartinez
Copy link
Collaborator

Adding back the audience network adapter and updating it to be compliant on 3.x.

You can see a diff from the 2.x and 3.x versions at the revision history of this GIST:

https://gist.github.com/robertrmartinez/cc4cc72fd1445f0096775aac36305583/revisions

@bretg
Copy link
Collaborator

bretg commented Jan 22, 2020

@lovell - we'd like you to have a chance to review and approve this PR. Thanks.

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the gist with the diffs.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bretg
Copy link
Collaborator

bretg commented Jan 23, 2020

Going ahead to merge this as many are waiting on it. The testing done looks reasonable to me. @lovell , we'd still invite you to review the change.

@bretg bretg merged commit c760ca5 into master Jan 23, 2020
@lovell
Copy link
Contributor

lovell commented Jan 24, 2020

Thanks for restoring this adapter. There's a new version coming along soon but this will provide a stopgap for those wanting to use it with Prebid.js v3.

hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
@robertrmartinez robertrmartinez deleted the audience_network_update branch September 21, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants