Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests on dfp video module #5607

Closed
patmmccann opened this issue Aug 14, 2020 · 2 comments
Closed

unit tests on dfp video module #5607

patmmccann opened this issue Aug 14, 2020 · 2 comments
Assignees
@ChrisHuie
Labels
in progress pinned won't be closed by stalebot

Comments

@patmmccann
Copy link
Collaborator

#4821 and #5487 broke this module without creating any unit test issues. This was later fixed on #5591

Perhaps we need better unit testing on this module to prevent future breaks?
@patmmccann
Copy link
Collaborator Author

The issue might be contained to https://github.com/prebid/Prebid.js/blob/master/test/spec/modules/dfpAdServerVideo_spec.js#L42 Why did this particular expect not get flagged with the merge of 5487?

@bretg bretg added help wanted pinned won't be closed by stalebot labels Aug 19, 2020
@gglas
Copy link

gglas commented Mar 1, 2021

assigning to @ChrisHuie to explore if there are missing tests for these PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisHuie ChrisHuie

Labels
in progress pinned won't be closed by stalebot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@patmmccann @gglas @ChrisHuie @bretg