implements the todo comment in the code #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adUnit.sizes was still being referenced here in two places despite being deprecated. This simply deletes the references.
jaiminpanchal27
approved these changes
Feb 11, 2020
Fawke
dismissed
their stale review
Sorry, I found two unit test cases failing after approving this!
Fawke
requested changes
Feb 11, 2020
There was a problem hiding this comment.
Hi, thanks for this PR.
I believe there a two unit test cases which are failing in pbjs_api_spec.js in line: 1516 and line:1604 because we are still trying to assert against adUnit.sizes which you just removed in this PR.
Can you get rid of the assertions in those two line and then run the command, gulp test to validate all unit test cases are passing?
|
I found several other assertions to delete as well based on adUnits[0].sizes |
Fawke
approved these changes
Feb 12, 2020
jsnellbaker
added a commit
that referenced
this pull request
Feb 13, 2020
This reverts commit 469ec57.
jsnellbaker
added a commit
that referenced
this pull request
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adUnit.sizes was still being referenced here in two places despite being deprecated. This simply deletes the references.
Type of change-
[ ] Bugfix
Description of change
Removal of an object that is no longer needed
Other information
http://prebid.org/blog/pbjs-3