Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests are flaky #642

Closed
mkendall07 opened this issue Sep 19, 2016 · 0 comments
Closed

Unit tests are flaky #642

mkendall07 opened this issue Sep 19, 2016 · 0 comments
Assignees
@matthewlane
Labels
build process
Milestone
Prebid 0.14.0

Comments

@mkendall07
Copy link
Member

It's been observed that random undefined type errors fail the build occasionally.
@mkendall07 mkendall07 added this to the Prebid 0.14.0 milestone Sep 19, 2016
matthewlane added a commit that referenced this issue Sep 27, 2016
@matthewlane
Catch debug-mode exceptions
668a233 
These changes aim to catch the exceptions that are displayed in the console when leaving Karma in debug mode. In some cases, such as the changes that affect adapters, it may be necessary to alter what happens in the catch block. For now the goal was to catch exceptions with minimal changes to the existing code. These changes do not completely eliminate, but may reduce the flaky failures referenced in #642.
@marian-r marian-r mentioned this issue Sep 27, 2016
Merged
8 tasks
This was referenced Sep 29, 2016
Merged
Merged
Merged
Merged
Merged
mkendall07 added a commit that referenced this issue Oct 4, 2016
@mkendall07
Address #642 - adLoader was not being stubbed, thus resulting in re…
384ed27 
…questing resources that are not always script responses. This should resolve `script error` type build failures
@mkendall07 mkendall07 mentioned this issue Oct 4, 2016
Merged
1 task
mkendall07 pushed a commit that referenced this issue Oct 5, 2016
Address #642 - adLoader was not being stubbed, thus resulting in re…
b385300 
…questing resources that are not always script responses. This should resolve `script error` type build failures (#678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewlane matthewlane

Labels
build process
Projects
None yet
Milestone
Prebid 0.14.0
Development

No branches or pull requests
2 participants
@matthewlane @mkendall07