Add error event if the server responds with an error

[fasenderos]

Hi all, for tracking purpouse I need to have an event if the server responds with an error. Something like BIDDER_ERROR, to be used in the adapter with onBidderError. If you think it could be usefull I can make a PR for that. Thanks

[ChrisHuie]

I think it would be a useful PR or if you think it is better as documentation I can update the docs if you paste in your code.

[fasenderos]

Hi @ChrisHuie apologies for the slow reply. I'm not sure this is the best way for firing the error event because I do not have an extensive knowledge of the prebid framework. Anyway these are the modifications I have done:

1) Defined the event "BIDDER_ERROR": "bidderError" in the constants.json file after this line

Prebid.js/src/constants.json

Line 34 in 253600d

"BIDDER_DONE": "bidderDone",

2) Trigger bidder's onBidderError handler and emit the BIDDER_ERROR event, in the onFailure function of the bidderFactory:

/ **
* NOTE the original onFailure only accepts the error message and not the error object, even though ajax.js passes them both.
* For tracking purpose we need also the error object
*/
function onFailure(errorMessage, error) {
    onTimelyResponse(spec.code);
    adapterManager.callBidderError(spec.code, error, bidderRequest)
    events.emit(CONSTANTS.EVENTS.BIDDER_ERROR, { error, bidderRequest });
    logError(`Server call for ${spec.code} failed: ${errorMessage} ${error.status}. Continuing without bids.`);
    onResponse();
}

3) Add the callBidderError function at the end of the adapterManager

adapterManager.callBidderError = function(bidder, error, bidderRequest) {
  const param = { error, bidderRequest };
  tryCallBidderMethod(bidder, 'onBidderError', param);
};

With that I was able to listen for the event onBidderError in my adapter.

 /**
   * Track error
   * @param {XMLHttpRequest.error} error
   * @param {BidderRequest} bidderRequest
   */
  onBidderError: function ({ error, bidderRequest }) {
      .... some logic here
  }

If that make sense for you I can make a PR.

[fasenderos]

2) Trigger bidder's onBidderError handler and emit the BIDDER_ERROR event, in the onFailure function of the bidderFactory:

adapterManager.callBidderError(spec.code, error, bidderRequest)
events.emit(CONSTANTS.EVENTS.BIDDER_ERROR, { error, bidderRequest });

Here I know that triggering only the onBidderError handler is enough for my purpose, but the event can be consumed by other bidders and analytics pixels