PBjs core: new BIDDER_ERROR event and onBidderError function called when ajax call fail #7438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
added
feature
needs 2nd review
Fawke
requested changes
Sep 24, 2021
There was a problem hiding this comment.
Hi @fasenderos,
Thanks for the PR, this change looks good. I was able to test it locally and it seemed to be working fine.
I'd request you to update the docs by creating a docs PR and update the events section here
|
@Fawke sure, but I can’t guarantee for my English. |
|
@Fawke docs PR prebid/prebid.github.io#3308 |
|
@fasenderos Thank you for the docs PR. @robertrmartinez When you get a chance, can you please review this PR? Thanks. |
robertrmartinez
approved these changes
Oct 12, 2021
Fawke
approved these changes
Oct 18, 2021
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When the ajax request fail a new error event
BIDDER_ERRORwill be emitted and adapters can registering to the new function onBidderError. Related issue #6756