Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubmatic BidAdapter potentially doesn't assign mediaType correctly when referencing a BidResponse's ext.bidtype. #7645

Closed
DecayConstant opened this issue Oct 29, 2021 · 3 comments
Assignees
Labels

Comments

@DecayConstant
Copy link

Type of issue

Bug

Description

When a Pubmatic BidResponse contains ext.bidtype, the code in the _checkMediaType function incorrectly tries to access it with ext.BidType (https://github.com/prebid/Prebid.js/blob/master/modules/pubmaticBidAdapter.js#L869)

This is causing the BidAdapter to sometimes incorrectly assign mediaTypes.

Steps to reproduce

Get a BidReponse from Pubmatic, and inspect the contents of its ext. It will contain ext.bidtype instead of ext.BidType

Expected results

I expect the Adapter to correctly access the ext.bidtype in the BidResponse.

Actual results

The bidAdapter is sometimes incorrectly assigning a mediaType of 'banner' to Outstream BidReponses that should have a MediaType of video
Caramel_Chicken_-_Vietnamese_Caramel_Chicken_-_Rasa_Malaysia
.

@pm-harshad-mane
Copy link
Contributor

Thank you @DecayConstant for reporting.
i will look into this one.

@pm-harshad-mane pm-harshad-mane self-assigned this Nov 1, 2021
pm-harshad-mane added a commit to pm-harshad-mane/Prebid.js that referenced this issue Nov 1, 2021
@pm-harshad-mane
Copy link
Contributor

PBS implementation of PubMatic bid adapter also expect BidType instead of bidtype

@gglas gglas added the bug label Nov 8, 2021
@pm-harshad-mane
Copy link
Contributor

The bug is fixed in #7683, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants