Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoo Bid Adapter: Rebrand to Yahoo Advertising #10125

Merged
merged 8 commits into from
Jul 10, 2023

Conversation

slimkrazy
Copy link
Contributor

@slimkrazy slimkrazy commented Jun 20, 2023

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Rebrand to Yahoo Advertising. Bid adapter introduces a new yahooAdvertising bidder code, but continues to support the legacy yahoossp alias.

Other information

Documentation site PR is here

@radubarbos, please cast your eye over this.

@@ -6,9 +6,9 @@ import { Renderer } from '../src/Renderer.js';
import {hasPurpose1Consent} from '../src/utils/gpdr.js';

const INTEGRATION_METHOD = 'prebid.js';
const BIDDER_CODE = 'yahoossp';
const BIDDER_CODE = 'yahooAdvertising';
const BIDDER_ALIASES = ['yahoossp']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe yahoo as well?

You are welcome to change your bidder code and alias the old adapter, however, changing the filename is breaking because of the build instructions.

With `modules.json` containing the following

You'll have to wait for prebid 9 to do that. We just shipped Prebid 8 last week.

@@ -6,9 +6,9 @@ import { Renderer } from '../src/Renderer.js';
import {hasPurpose1Consent} from '../src/utils/gpdr.js';

const INTEGRATION_METHOD = 'prebid.js';
const BIDDER_CODE = 'yahoossp';
const BIDDER_CODE = 'yahooAdvertising';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be quite annoying for publishers, as the key names in gam are restricted to 20 characters

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought this too. We will go back to product with this issue to get their thoughts on it

@slimkrazy
Copy link
Contributor Author

Hey @patmmccann - We've been instructed not to use just 'yahoo' as that is for the consumer side of the business.

What we are doing now is to rename as 'yahooAds' for the bidder code. Documentation can retain the full brand name "Yahoo Advertising". We'll add 'yahooAdvertising' as an alias seeing as this bidder code was released in both PBS projects.

slimkrazy pushed a commit to slimkrazy/prebid.github.io that referenced this pull request Jun 27, 2023
@patmmccann
Copy link
Collaborator

patmmccann commented Jun 27, 2023

lgtm, but your spec file changed names, can you make sure that filename isn't changed and we're good to go

@slimkrazy
Copy link
Contributor Author

@patmmccann - All done.

@slimkrazy
Copy link
Contributor Author

@patmmccann - Please hold off merging this just yet. There's another issue that may need resolving.

@slimkrazy
Copy link
Contributor Author

@patmmccann - should be good to go now. Needed to make sure consent data was sent to our servers correctly in all cases and added an additional test.

@slimkrazy
Copy link
Contributor Author

Hey @patmmccann - is there a chance that somebody could help us get this one over the line before the next release?

@patmmccann patmmccann merged commit 38aacce into prebid:master Jul 10, 2023
@patmmccann
Copy link
Collaborator

@slimkrazy Thanks for the updates!

@slimkrazy slimkrazy changed the title Yahoo Bid Adapter: Rebrand from to Yahoo Advertising Yahoo Bid Adapter: Rebrand to Yahoo Advertising Jul 11, 2023
github-ishara-chan-tung pushed a commit to ebuzzing/Prebid.js that referenced this pull request Jul 12, 2023
* Yahoo bid adapter rebrand

* Add deleted modules

* Addressing PR feedback

* Updated docs

* Renamed spec file

* Ensure consent data is pulled and sent correctly

---------

Co-authored-by: slimkrazy <sam@slimkrazy.com>
ChrisHuie pushed a commit to prebid/prebid.github.io that referenced this pull request Jul 21, 2023
* Yahoo bid adapter rebrand documentation

* bidder code change as per comments in prebid/Prebid.js#10125

---------

Co-authored-by: slimkrazy <sam@slimkrazy.com>
santii7395 pushed a commit to themaven-net/Prebid.js that referenced this pull request Aug 28, 2023
* Yahoo bid adapter rebrand

* Add deleted modules

* Addressing PR feedback

* Updated docs

* Renamed spec file

* Ensure consent data is pulled and sent correctly

---------

Co-authored-by: slimkrazy <sam@slimkrazy.com>
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* Yahoo bid adapter rebrand documentation

* bidder code change as per comments in prebid/Prebid.js#10125

---------

Co-authored-by: slimkrazy <sam@slimkrazy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants