-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinuteMedia Bid Adapter: support missing params and tests #10195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added isWrapper param
addes is_wrapper parameter to documentation
ChrisHuie
approved these changes
Jul 10, 2023
github-ishara-chan-tung
pushed a commit
to ebuzzing/Prebid.js
that referenced
this pull request
Jul 12, 2023
* add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space * Upgrade Rise adapter to 5.0 * added isWrapper param * addes is_wrapper parameter to documentation * added is_wrapper to test * removed isWrapper * Rise Bid Adapter: support Coppa param (prebid#24) * MinuteMedia Bid Adapter: support Coppa param (prebid#25) * Revert "MinuteMedia Bid Adapter: support Coppa param (prebid#25)" (prebid#26) This reverts commit 66c4e7b. * bump * update coppa fetch * setting coppa param update * update Coppa tests * update test naming * Rise Bid Adapter: support plcmt and sua (prebid#27) * update minuteMediaBidAdapter - support missing params (prebid#29) --------- Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com> Co-authored-by: noamtzu <noamtzu@gmail.com> Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com> Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com> Co-authored-by: OronW <41260031+OronW@users.noreply.github.com> Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com> Co-authored-by: inna <innayare@gmail.com> Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
* add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space * Upgrade Rise adapter to 5.0 * added isWrapper param * addes is_wrapper parameter to documentation * added is_wrapper to test * removed isWrapper * Rise Bid Adapter: support Coppa param (#24) * MinuteMedia Bid Adapter: support Coppa param (#25) * Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26) This reverts commit 66c4e7b. * bump * update coppa fetch * setting coppa param update * update Coppa tests * update test naming * Rise Bid Adapter: support plcmt and sua (#27) * update minuteMediaBidAdapter - support missing params (#29) --------- Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com> Co-authored-by: noamtzu <noamtzu@gmail.com> Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com> Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com> Co-authored-by: OronW <41260031+OronW@users.noreply.github.com> Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com> Co-authored-by: inna <innayare@gmail.com> Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding missing params and tests.