Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for downloading Analytics Adapters via http://prebid.org/download.html #1021

Merged
merged 14 commits into from
Mar 30, 2017
Merged

Support for downloading Analytics Adapters via http://prebid.org/download.html #1021

merged 14 commits into from
Mar 30, 2017

Conversation

anand-venkatraman
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

In order to be able to build prebid.js from the Downloads page, this change would help specifying analytics adapters to include in the bundle. This change was requested as part of prebid/prebid.github.io#132

@anand-venkatraman anand-venkatraman changed the title Analytics Support for downloading Analytics Adapters via http://prebid.org/download.html Mar 2, 2017
@mkendall07 mkendall07 assigned mkendall07 and unassigned protonate Mar 2, 2017
@mkendall07
Copy link
Member

can you modify this so that you can pass in a path to the file, the same way you can for standard adapters? Thanks!

analytics.json Outdated
"ga",
"pulsepoint",
"roxot",
"sharethrough_analytics"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove these as this will change the default behavior of building with all the analytics adapters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all the analytics adapter entries in the file. Though I think, it is probably a good idea to bundle all of them in the default build.

@mkendall07
Copy link
Member

mkendall07 commented Mar 30, 2017

@snapwich @bretg
Are you ok with this breaking change for including analytics adapters in the build - as a interim solution before the major refactor?

Edit: this removes analytics array out of package.json.

@snapwich
Copy link
Collaborator

yeah this is fine with me.

@mkendall07
Copy link
Member

LGTM.

@mkendall07 mkendall07 merged commit 4b880ec into prebid:master Mar 30, 2017
@ptomasroos
Copy link
Contributor

Docs are outdated on building from local checkout repo.
Can't get any analytics into the build anymore. Pretty sure this PR killed it.

Plus there are no tests covering the usage of analytics.json in the build as far as I can tell

@ptomasroos
Copy link
Contributor

New syntax is

gulp build --adapters adapters.json --analyticsAdapters analytics.json

With an array defined in analytics.json

vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 19, 2017
…19.0 to aolgithub-master

* commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits)
  Disable unit tests that fails on PhantomJs.
  Fixed unit tests for adapter loader.
  Changed way of including analytic adapters.
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Replace removed utils.extend functionality by object.assign.
  Add Inneractive adapter (prebid#1048)
  Add alias freewheel-ssp to stickyadstv bidder adapter  (prebid#1043)
  Add Facebook Audience Network adapter (prebid#1068)
  Add Atomx support (prebid#1056)
  Updated rubicon video bid endpoint in source and test files (prebid#1097)
  Pass through params to server (prebid#1084)
  Reset the list of slots to be requested between each action for pubmatic (prebid#1079)
  Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021)
  update PR template to include link to dev docs page (prebid#1075)
  Prebid 0.21.0
  Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054)
  Video header bidding support to RhythmOne bidder adapter (prebid#1052)
  Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045)
  Fix adapter getSize (prebid#1064)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants