sharethrough: wait for document.body to exist #1026
Conversation
If document.body doesn't exist yet, wait for content loaded event from document before adding iframe.
|
Is there a reason you use an iFrame to load JSONP content rather than a script tag? Also, Prebid.js provides I'm pretty sure an iFrame is going to both slow down the auction as well as put you guys at a disadvantage as far as response time. |
|
@snapwich I'm not a sharethrough developer, so I can't comment specifically on their loading procedure. Using JSONP directly instead of their iframe solution seems a lot simpler to me as well. With the current parameters, their bid server returns HTML containing a script tag with the callback, so not JSONP per se (they use the term ijson). It looks like @rizhang made the initial commit, so perhaps they can comment on it? |
|
We used an iframe because that is how are endpoint is meant to be consumed and we didn't want to do any backend work to support jsonp. I made a PR to use ajax instead of an iframe hoping that it will speed up our response times. #1042 |
|
@rizhang thanks for your PR and backend change, it seems to work so I'll close this |
Type of change
Description of change
If document.body doesn't exist yet, wait for content loaded event
from document before adding iframe.
Other information
Fixes issue #1025