appnexus bid adapter - update to work with native ortb #10321
+491
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsnellbaker I'm confused? If you're requesting review can you remove the draft status and re-assign a reviewer? Removed for now due to being in draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR updates the logic in the
appnexusBidAdapter.jsfile to read/write native data from/to ortb objects.There are some caveats around the img sizes and aspect_ratios fields when building the request; this is due to multiple sets of sizes/aspect_ratios available with the prebid legacy native setup (see #10249 discussion).
Another thing to note (which is mainly why this is still in draft), I can't seem to get the targeting keys to generate with the asset# pattern. Prebid Core still seems to make the legacy targeting keys even though I make an adunit only use the
native.ortbsetup. If there's any suggestions about what to do to make this work, please let me know. I had assumed writing the data to thebidResponse.native.ortbwould have been sufficient.