-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jixie adapter changes: adding sendingi of gpid, and send several ids that sits in first party cookie #10369
Conversation
…6650 added response comment and some trivial code.
added a space behind the // in comments
…ain in unit tests
* jixie_add_keyword_frompage: added the code to get the keywords from the meta tags if available.
merge up to origin's master
take latest from upstream
merge up to latest in opensrc prebidjs
* master: (107 commits) Increment version to 8.11.0-pre Prebid 8.10.0 release add privacyIcon to not native asset list (prebid#10259) gppControl_usstates: activity controls for US state consent (prebid#10283) UserID: check for all consent (not just GDPR) to check if an ID needs refreshing (prebid#10286) fluct Bid Adapter: add user.data to bid requests (prebid#10318) Prebid Server adapter: improve cookie_sync tests, check GPP fields are populated (prebid#10362) fix: consolidate banner format array (prebid#10365) consentManagementGpp: support GPP 1.1 (prebid#10282) Relay Bid Adapter : Initial Release (prebid#10197) Yieldmo Bid Adapter : adding 4.x VAST protocol support (prebid#10363) Cadent Aperture MX Bid Adapter: support GPP and GPP Section Ids (prebid#10342) identityLinkSubmodule: add additional check on retrieving the envelope (prebid#10355) fluct Bid Adapter: add gpid to bid requests (prebid#10361) Increment version to 8.10.0-pre Prebid 8.9.0 release fledgeForGpt: consolidate publisher configuration (prebid#10360) ConcertBidAdapter: Add `browserLanguage` to request `meta` object (prebid#10356) GrowthCode Analytics: Updates/BugFixes (prebid#10339) Activity Controls GPP: invalidate covered = 0 in mspa (prebid#10354) ...
* rw-jixie-pass-gpid-etc: sending gpid; sending a few more ids from first party cookie
@jxdeveloper1 can you fix your code regarding the CI please? |
Hi ! I have corrected the indentation issue of the first CI failure. The second time, it seems the error is related to another adapter. What should I do? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Jixie adapter changes: adding sending of gpid, and send several ids that sits in first party cookie