-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outbrain adapter: Read OB user token from local storage #10382
Merged
robertrmartinez
merged 6 commits into
prebid:master
from
Zemanta:ob-user-token-localstorage
Oct 3, 2023
+31
−3
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
29b3ea6
read ob user token from local storage
markkuhar 1d2e044
lint fix
markkuhar 4c653e4
add test
markkuhar f726669
Merge branch 'master' into ob-user-token-localstorage
markkuhar 9fd5d42
test improvement
markkuhar f2b8e67
Merge branch 'master' into ob-user-token-localstorage
markkuhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be a stickler on this but could you please do the stubbing and restoring in the before and after hooks?
This helps us not hurt downstream tests if for some reason your test fails in the middle of execution.
I know other adapters have it, but trying to set a better standard:
IX has a good example of this: https://github.com/prebid/Prebid.js/blob/master/test/spec/modules/ixBidAdapter_spec.js#L3814-L3833
Or you could use a sandbox if you were stubbing more things, but prob not needed.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, thanks for the suggestion! I don't want to stub return of the method before each test because I don't want to fix other tests (the response should stay the same if we don't read anything from local storage). So I hope this is ok
9fd5d42