Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sspBC Bid Adapter: add support for topicsFpdModule #10416

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

wojciech-bialy-wpm
Copy link
Contributor

Type of change

  • Feature

Description of change

Add support for User.data segments 600-609 (topics data created by topicsFpdModule.js).
Reformat data so it's properly parsed by sspBC exchange.

Copy link
Collaborator

@dgirardi dgirardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -199,6 +199,22 @@ const applyClientHints = ortbRequest => {
ortbRequest.user = { ...ortbRequest.user, ...ch };
};

const applyTopics = (validBidRequest, ortbRequest) => {
const userData = validBidRequest.ortb2?.user?.data || [];
const topicsData = userData.filter(dataObj => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ortb2 object you get as input is meant to be usable as-is for your ORTB exchange, so I'm always curious to learn why the extra processing.

From what I see here you prefer to:

  • not get all the available user data segments, but only topics;
  • not get information about who provided the topics (data[].name).

Both choices seem odd to me, which is why I note them here, but of course you're free to make them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our exchange is, unfortunately, not fully ortb-compliant - that's why we:
a) trim data in topics
b) custom-build other user segments (see applyClientHints etc)

The next major version of the adapter should use ortbConverter, but we're waiting for the changes on the backend (to eliminate the need for overrides on the adapter side).

@ChrisHuie ChrisHuie merged commit 550a7cb into prebid:master Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants