-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IX Bid Adapter: add support for signaling privacy sandbox (fledge) auction requests [PB-1841] #10537
Merged
lksharma
merged 7 commits into
prebid:master
from
indexexchange:PB-1841-fledge-signal-for-ix-addapter
Oct 4, 2023
Merged
IX Bid Adapter: add support for signaling privacy sandbox (fledge) auction requests [PB-1841] #10537
lksharma
merged 7 commits into
prebid:master
from
indexexchange:PB-1841-fledge-signal-for-ix-addapter
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add test coverage [PB-1841] feat: add more test coverage [PB-1841] feat: fix code smell [PB-1841] feat: fix code smell [PB-1841] feat: fix code smell and update test adunit code [PB-1841] feat: update ix adapter doc for fledge [PB-1841] feat: update auction config response interpretation [PB-1841] fix: fix typo [PB-1841] fix: add missing null check for banner ext [PB-1841] fix: add missing null check for banner ext [PB-1841] feat: update interpret response to consider igbid in response ext [PB-1841] feat: add extra validation and tests [PB-1841] feat: add test case [PB-1841] feat: update interpret response with new auctiuon confis [PB-1841] fix: update config name feat: update tests for new auction configs list response [PB-1841]
shahinrahbariasl
changed the title
feat: add support for signaling fledge auction request [PB-1841]
feat: add support for signaling privacy sandbox (fledge) auction request [PB-1841]
Oct 3, 2023
shahinrahbariasl
changed the title
feat: add support for signaling privacy sandbox (fledge) auction request [PB-1841]
feat: add support for signaling privacy sandbox (fledge) auction requests [PB-1841]
Oct 3, 2023
@shahinrahbariasl please name your pr as 'x adapter: change' |
shahinrahbariasl
changed the title
feat: add support for signaling privacy sandbox (fledge) auction requests [PB-1841]
IX Bid Adapter: add support for signaling privacy sandbox (fledge) auction requests [PB-1841]
Oct 3, 2023
Opps, sry about that! It's been a while I haven't opened a PR here and forgot. It's updated now. |
lksharma
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Note: receiving actually PA demand is TBD.
Other information
For more information please contact shahin.rahbariasl@indexexchange.com.