Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doceree Bid Adaptor: bidwon and timeout hooks added #10543

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

sourbh-doceree
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@jsnellbaker jsnellbaker self-assigned this Sep 29, 2023
@jsnellbaker jsnellbaker self-requested a review September 29, 2023 11:59
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look fine, but can you please add some unit tests and address the linting errors (seen in the circleci test)?

We should be good to merge after that.

@jsnellbaker jsnellbaker merged commit 25bd335 into prebid:master Oct 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants