Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imds Bid Adapter : fix incorrectly named user sync property #10562

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

ecammit
Copy link
Contributor

@ecammit ecammit commented Oct 3, 2023

Type of change

  • Bugfix

Description of change

  • This changes the "image" usersync from the incorrectly used "pixel" property. This was preventing the new image user sync from happening and causing a warning in the console with debug enabled of: WARNING: User sync type "pixel" not supported.
  • Removed a warning being emitted for valid 204 no-bid responses with an empty body.
  • There is also a change to the markdown documentation to match imds: Update Google Ad Manager video tag information prebid.github.io#4908

Other information

prebid/prebid.github.io#4908

@ecammit
Copy link
Contributor Author

ecammit commented Oct 3, 2023

Note: Failing circleci is from some unrelated bid adapter (lm_kiviadsBidAdapter) that's consistently failing.

@ecammit ecammit changed the title imds: Fix incorrectly named user sync property and update documentation imds: Fix incorrectly named user sync property Oct 3, 2023
@ChrisHuie ChrisHuie changed the title imds: Fix incorrectly named user sync property imds Bid Adapter : fix incorrectly named user sync property Oct 4, 2023
@ChrisHuie ChrisHuie self-assigned this Oct 4, 2023
@ChrisHuie ChrisHuie merged commit 8cb373c into prebid:master Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants