Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubmaticBidAdapter: Read and pass gpid from ortb2imp.ext in API call #10577

Merged
merged 7 commits into from
Oct 13, 2023
Merged

PubmaticBidAdapter: Read and pass gpid from ortb2imp.ext in API call #10577

merged 7 commits into from
Oct 13, 2023

Conversation

pm-priyanka-deshmane
Copy link
Contributor

Type of change

[x] Feature

Description of change

Reading the gpid from ortb2Imp.ext in adunits and pass it to translator call.

@patmmccann patmmccann self-assigned this Oct 5, 2023
@patmmccann patmmccann self-requested a review October 5, 2023 12:51
kicking off tests by committing as me
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending circleci checks

@patmmccann
Copy link
Collaborator

seems like you are following your own fork in circleci and this prevents our tests from kicking off

@pm-priyanka-deshmane
Copy link
Contributor Author

@patmmccann can you merge this ?

@pm-priyanka-deshmane
Copy link
Contributor Author

@jlquaccia can we merge this ?

Copy link
Collaborator

@jlquaccia jlquaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems everything is passing now

@jlquaccia jlquaccia merged commit ea39308 into prebid:master Oct 13, 2023
2 checks passed
pm-priyanka-deshmane added a commit to PubMatic-OpenWrap/Prebid.js that referenced this pull request Oct 19, 2023
…rebid#10577)

* Pass gpid value from ortb2Imp.ext in translator call

* Update pubmaticBidAdapter_spec.js

kicking off tests by committing as me

* Test

* Test

* Update pubmaticBidAdapter_spec.js

* Commit to retrigger test cases

---------

Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants