-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new Trion Interactive Adapter and associated tests to prebid. #1059
Conversation
Hey @grohm33 ,just a heads up that you may want to also submit a PR to have your adaptor documented on prebid.org :-) https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders |
@aneuway2 I added the pull request for documentation. Thanks for the heads up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests pass, but I'm not getting actual bids, every response using the test config is pbjs.handleTrionCB({"result":{"placeBid":false}});
. I'm testing from localhost on port 9999.
cc: @grohm33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide test params that return bids
@protonate We just set up a test ad to return from pubId : '30222' and sectionId : '5'. In order for this to return a bid you also need to be mobile user agent. Let me know if that works for you. Thanks! |
Thanks, getting bids back now with those test params, LGTM |
…built * 'master' of https://github.com/prebid/Prebid.js: (23 commits) Prebid 0.22.2 Release Renderer test - use httpbin/post endpoint in place of domain alone AdKernal - comment out console.warn in test WideOrbit - remove test referencing url with redirect add karma-es5-shim again via yarn Widespace - fix lint error on build and test Fix Object.assign support for IE11 & < Widespace - use forEach in place of for...of Underdogmedia - use forEach in place of for...of PlusepointLite - comment out breaking tests Prebid 0.22.1 Release set babel plugins @6.22.0 lock down babel packages @6.24.1 PulsePointLite: comment out breaking adapter test Prebid 0.22.0 Release Update polyfills to use core-js. (prebid#1142) Mantis - comment out breaking test Add Trion Interactive adapter (prebid#1059) HuddledMasses header bidding adapter (prebid#1095) Add support for custom floor value in rubicon video and increased code coverage. (prebid#1102) ...
* Adding a new Trion Interactive Adapter and associated tests to prebid. * adding pub and section id grab before user sync is called
Type of change
Description of change
Adding Trion adapter
mgroh@trioninteractive.com
Other information