Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new Trion Interactive Adapter and associated tests to prebid. #1059

Merged
merged 2 commits into from
Apr 19, 2017

Conversation

grohm33
Copy link
Contributor

@grohm33 grohm33 commented Mar 21, 2017

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Adding Trion adapter

  • test parameters for validating bids
{
  bidder: 'trion',
  params: {
    pubId : 1,//required
    sectionId : 2,//required
    re : ''//third party redirect optional
  }
}

Other information

@aneuway2
Copy link
Contributor

Hey @grohm33 ,just a heads up that you may want to also submit a PR to have your adaptor documented on prebid.org :-)

https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders

@grohm33
Copy link
Contributor Author

grohm33 commented Mar 23, 2017

@aneuway2 I added the pull request for documentation. Thanks for the heads up!

Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests pass, but I'm not getting actual bids, every response using the test config is pbjs.handleTrionCB({"result":{"placeBid":false}});. I'm testing from localhost on port 9999.

cc: @grohm33

Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide test params that return bids

@grohm33
Copy link
Contributor Author

grohm33 commented Apr 19, 2017

@protonate We just set up a test ad to return from pubId : '30222' and sectionId : '5'. In order for this to return a bid you also need to be mobile user agent. Let me know if that works for you. Thanks!

@protonate
Copy link
Collaborator

Thanks, getting bids back now with those test params, LGTM

@matthewlane matthewlane merged commit cd72ad1 into prebid:master Apr 19, 2017
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Apr 26, 2017
…built

* 'master' of https://github.com/prebid/Prebid.js: (23 commits)
  Prebid 0.22.2 Release
  Renderer test - use httpbin/post endpoint in place of domain alone
  AdKernal - comment out console.warn in test
  WideOrbit - remove test referencing url with redirect
  add karma-es5-shim again via yarn
  Widespace - fix lint error on build and test
  Fix Object.assign support for IE11 & <
  Widespace - use forEach in place of for...of
  Underdogmedia - use forEach in place of for...of
  PlusepointLite - comment out breaking tests
  Prebid 0.22.1 Release
  set babel plugins @6.22.0
  lock down babel packages @6.24.1
  PulsePointLite: comment out breaking adapter test
  Prebid 0.22.0 Release
  Update polyfills to use core-js. (prebid#1142)
  Mantis - comment out breaking test
  Add Trion Interactive adapter (prebid#1059)
  HuddledMasses header bidding adapter (prebid#1095)
  Add support for custom floor value in rubicon video and increased code coverage. (prebid#1102)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Adding a new Trion Interactive Adapter and associated tests to prebid.

* adding pub and section id grab before user sync is called
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants