Yahoo ConnectId Module : backend sync updates. #10590
Conversation
ChrisHuie
changed the title
| @@ -104,9 +114,11 @@ function syncLocalStorageToCookie() { | |||
| } | |||
|
|
|||
| function isStale(storedIdData) { | |||
| if (isPlainObject(storedIdData) && storedIdData.lastSynced && | |||
| (storedIdData.lastSynced + VALID_ID_DURATION) <= Date.now()) { | |||
| if (isOAndOTraffic()) { | |||
There was a problem hiding this comment.
this feels like a lot of code to determine if your id is stale and needs to be re-synced. Why not just look for something in the environment only your O+o sets?
There was a problem hiding this comment.
I'll ask around but where a user is redirected from yahoo O&O page to partner pages there is nothing in the environment that is different and can be used.
There was a problem hiding this comment.
maybe you should set something instead of burdening the rest of the internet with this bulk
There was a problem hiding this comment.
or you could have your own properties fork your own adapter
There was a problem hiding this comment.
Hey @patmmccann,
Trust me when I say that both @radubarbos and I raised questions about this method. This is actually not for our properties, it is for third party properties that are clicked through to from our properties, hence the referrer check. This change request came straight from the identity team.
We will go back to that team one more time to see if there is another way that can work. Will get back to you asap.
There was a problem hiding this comment.
I was told that currently there is no custom traffic contract between yahoo and third party partners like query params or other information, there is only what the HTTP provides (referrer). If this was for our own pages we could have used something in the environment but on the third party pages we can't.
| @@ -127,6 +139,17 @@ function getSiteHostname() { | |||
| return pageInfo.hostname; | |||
| } | |||
|
|
|||
| function isOAndOTraffic() { | |||
There was a problem hiding this comment.
it is covered by this test
it('returns an object with the stored ID from cookies and syncs because is O&O traffic', () => {
const last2Days = Date.now() - (60 * 60 * 24 * 1000 * 2);
const last21Days = Date.now() - (60 * 60 * 24 * 1000 * 21);
const ttl = 60 * 60 * 24 * 1000 * 3;
const cookieData = {connectId: 'foo', he: HASHED_EMAIL, lastSynced: last2Days, puid: '9', lastUsed: last21Days, ttl};
getCookieStub.withArgs(STORAGE_KEY).returns(JSON.stringify(cookieData));
const getRefererInfoStub = sinon.stub(refererDetection, 'getRefererInfo');
getRefererInfoStub.returns({
ref: 'https://dev.fc.yahoo.com?test'
});```
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
[ x] Other
Description of change
Other information
The back-end user id syncs are done more each time for yahoo sources traffic and the id validity can be determited by a TTL value the back-end provides in hours.