TPMN Bid Adapter: Change End-Point & Support Video #10611

tpmn-admin · 2023-10-16T05:24:07Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

Change End-Point
Change Request Format (payload -> Ortb)
Support Video MediaType
Support OutStream Video
Update Document
Add Example (/integrationExamples/gpt/tpmn_example.html)

Other information

AbdullahWins

Good Job!

patmmccann · 2023-10-16T14:29:35Z

modules/tpmnBidAdapter.js

+  }
+  if (bid.params.inventoryId) rtbData.ext = {};
+  if (bid.params.inventoryId) rtbData.ext.inventoryId = bid.params.inventoryId
+  if (bid.params.bcat) rtbData.bcat = bid.params.bcat;


you have accept openrtb specification of bcat as well, you can take your params as an override

da8e928

update openrtb block attributes

patmmccann · 2023-10-16T14:31:34Z

modules/tpmnBidAdapter.js


-function getBannerSizes(bidRequest) {
-  return parseSizes(deepAccess(bidRequest, 'mediaTypes.banner.sizes') || bidRequest.sizes);
+  VIDEO_ORTB_PARAMS.forEach((param) => {


this seems unnecessary; the ortb convertor is already doing all this for you. Is that correct @dgirardi ?

i think.. this is needed to check which parameters are allowed.

I think this example does this with less code, as long as the parameters you're checking match the ones used in ortbConverter

2699115

I modified the code in the direction you suggested. ([this example] (https://github.com/prebid/Prebid.js/blob/master/libraries/ortbConverter/README.md#example-taking-video-parameters-from-bidrequestparamsvideo) )

Revert "remove VIDEO_ORTB_PARAMS, BANNER_ORTB_PARAMS"

I followed your recommendations, but the desired results were different.
First of all, the test case did not work as expected.

It is judged that overrides processing does not operate normally in TestCase.

When I tried to compare the contents of 'buildRequests()' in TestCase, it did not match.

patmmccann · 2023-10-16T14:31:55Z

modules/tpmnBidAdapter.js

+  'mimes',
+  'minduration',
+  'maxduration',
+  'placement',


you're missing plcmt

792fc2c
add plcmt

8bf7567
instream video is sound on default, outstream video sound off default

This reverts commit 2699115.

tpmn-admin · 2023-10-23T01:29:07Z

Hello. @dgirardi

I would like to request a review of the TPMN prebid.js pull request once again.

Regarding the code simplification using the previously mentioned 'ortbConverter,' we have decided to 'Revert' it.

We initially aimed to streamline the code using 'ortbConverter,' but the results generated using 'buildRequests' in the test cases behaved differently than expected.

In the test case 'should use bidder video params if they are set,' it does not perform as desired. We would like the new 'video parameter' settings to properly take effect when specifying them. The issue we encountered is that the new settings are not being reflected correctly, resulting in undesired outcomes.

The current code is working as intended at the moment.

I am requesting a code review in its current state.

Additionally, I'd like to inquire if there are any other points for consideration.

dgirardi · 2023-10-25T16:14:16Z

@tpmn-admin we're always looking to improve so I'm interested in more details on what was not working! I posted here the changes that I would submit for ortbConverter. Some notes:

I was not able to reproduce the video test failure, just following the example seems to work
My commit still has 1 test failure for ✖ should build correct request for banner bid with both w, h, because ortbConverter sets format instead of w and h. IMO format is better because it allows for multiple sizes, but of course it's your choice.
GDPR (and USP, GPP, etc) is also handled by ortbConverter, as well as site, so I removed those parts. I updated the tests as well since they need to be set up in a slightly different way.
Prebid does not expect to find battr in either mediaTypes.video or mediaTypes.banner - it's not in the list of options for those objects. I updated a test case to set it in params.

test/spec/modules/tpmnBidAdapter_spec.js

tpmn-admin · 2023-10-31T05:40:16Z

@dgirardi

I followed the guide(30ed60e) and used ortbConverter, removing unnecessary code in the process.
I realized later that I hadn't considered the 'test-all-features-disabled' case when writing the test code, so I made the necessary adjustments.
Now, the tests are running good.

dgirardi

I forgot to mention the feature disabled tests - sorry! This LGTM pending log cleanup that I mention below if you agree.

dgirardi · 2023-10-31T17:04:49Z

modules/tpmnBidAdapter.js

-      }
-      if (uspConsent && uspConsent.consentString) {
-        policyParam += `&ccpa_consent=${uspConsent.consentString}`;
+    utils.logWarn('Building bidResponse');


I'm not sure if I missed these in my previous review - I don't think they belong here, perhaps this was to help during development? Prebid already logs requests and responses.

I added it while creating example.html, and it was reflected as is. I will remove that part.

tpmn-admin · 2023-11-03T04:37:50Z

@patmmccann Please request a code review once again.

tpmn-admin · 2023-11-13T07:06:06Z

@dgirardi
It looks like not progressing. What else should we do for the next steps?
Please let me know if I'm missing anything.

TPMN Support Video

d717131

AbdullahWins reviewed Oct 16, 2023

View reviewed changes

patmmccann reviewed Oct 16, 2023

View reviewed changes

patmmccann added the feature label Oct 16, 2023

changjun added 3 commits October 17, 2023 12:12

add video param plcmt

792fc2c

update ortb bcat,badv,bapp

da8e928

instream video is sound on default, outstream video sound off default

8bf7567

tpmn-admin force-pushed the master branch from cdbd074 to 8bf7567 Compare October 17, 2023 03:31

changjun added 2 commits October 18, 2023 14:27

remove VIDEO_ORTB_PARAMS, BANNER_ORTB_PARAMS

2699115

fixed incorrect placement default format & update example

7942b31

tpmn-admin force-pushed the master branch from 92c5798 to ea31413 Compare October 18, 2023 09:40

update test case (Your tests failed on CircleCI)

21254cb

tpmn-admin force-pushed the master branch from ea31413 to 21254cb Compare October 18, 2023 09:49

Revert "remove VIDEO_ORTB_PARAMS, BANNER_ORTB_PARAMS"

1901ef1

This reverts commit 2699115.

tpmn-admin requested review from dgirardi and patmmccann October 19, 2023 01:22

ChrisHuie assigned dgirardi Oct 20, 2023

dgirardi added a commit to dgirardi/Prebid.js that referenced this pull request Oct 25, 2023

prebid#10611 suggestions

30ed60e

tpmn-admin force-pushed the master branch from 704e0d1 to 20a7ebe Compare October 30, 2023 01:33

tpmn-admin commented Oct 30, 2023

View reviewed changes

test/spec/modules/tpmnBidAdapter_spec.js Outdated Show resolved Hide resolved

Remove unnecessary code to meet guidelines.

f80a730

tpmn-admin force-pushed the master branch from 2cad415 to f80a730 Compare October 30, 2023 05:34

This comment was marked as resolved.

Sign in to view

Remove unnecessary code to meet guidelines.

97b1761

tpmn-admin force-pushed the master branch from 68c8028 to 97b1761 Compare October 31, 2023 02:01

tpmn-admin closed this Oct 31, 2023

tpmn-admin reopened this Oct 31, 2023

fix Build fail

4a85650

dgirardi approved these changes Oct 31, 2023

View reviewed changes

delete logging code

6ca428c

tpmn-admin requested a review from AbdullahWins November 9, 2023 02:36

patmmccann approved these changes Nov 13, 2023

View reviewed changes

patmmccann merged commit 76e967a into prebid:master Nov 13, 2023
4 checks passed

ChrisHuie mentioned this pull request Nov 28, 2023

Update PrebidJS Description prebid/prebid.github.io#4995

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TPMN Bid Adapter: Change End-Point & Support Video #10611

TPMN Bid Adapter: Change End-Point & Support Video #10611

tpmn-admin commented Oct 16, 2023 •

edited

Loading

AbdullahWins left a comment

patmmccann Oct 16, 2023

tpmn-admin Oct 17, 2023

patmmccann Oct 16, 2023

tpmn-admin Oct 17, 2023

dgirardi Oct 17, 2023

tpmn-admin Oct 18, 2023 •

edited

Loading

patmmccann Oct 16, 2023

tpmn-admin Oct 17, 2023

tpmn-admin commented Oct 23, 2023

dgirardi commented Oct 25, 2023

This comment was marked as resolved.

tpmn-admin commented Oct 31, 2023

dgirardi left a comment

dgirardi Oct 31, 2023

tpmn-admin Nov 1, 2023

tpmn-admin commented Nov 3, 2023

tpmn-admin commented Nov 13, 2023

TPMN Bid Adapter: Change End-Point & Support Video #10611

TPMN Bid Adapter: Change End-Point & Support Video #10611

Conversation

tpmn-admin commented Oct 16, 2023 • edited Loading

Type of change

Description of change

Other information

AbdullahWins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tpmn-admin Oct 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tpmn-admin commented Oct 23, 2023

dgirardi commented Oct 25, 2023

This comment was marked as resolved.

tpmn-admin commented Oct 31, 2023

dgirardi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tpmn-admin commented Nov 3, 2023

tpmn-admin commented Nov 13, 2023

tpmn-admin commented Oct 16, 2023 •

edited

Loading

tpmn-admin Oct 18, 2023 •

edited

Loading