-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon Bid Adapter: PAAPI/Fledge support #10671
Changes from all commits
5773078
18498e1
f4cfe66
7bc66c8
ffcac85
feed8a9
4af70c0
c76b4fd
598ec6a
aeab715
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -408,6 +408,7 @@ export const spec = { | |
'x_source.tid', | ||
'l_pb_bid_id', | ||
'p_screen_res', | ||
'o_ae', | ||
'rp_floor', | ||
'rp_secure', | ||
'tk_user_key' | ||
|
@@ -520,6 +521,10 @@ export const spec = { | |
if (configUserId) { | ||
data['ppuid'] = configUserId; | ||
} | ||
|
||
if (bidRequest?.ortb2Imp?.ext?.ae) { | ||
data['o_ae'] = 1; | ||
} | ||
// loop through userIds and add to request | ||
if (bidRequest.userIdAsEids) { | ||
bidRequest.userIdAsEids.forEach(eid => { | ||
|
@@ -619,7 +624,7 @@ export const spec = { | |
* @param {*} responseObj | ||
* @param {BidRequest|Object.<string, BidRequest[]>} request - if request was SRA the bidRequest argument will be a keyed BidRequest array object, | ||
* non-SRA responses return a plain BidRequest object | ||
* @return {Bid[]} An array of bids which | ||
* @return {{fledgeAuctionConfigs: *, bids: *}} An array of bids which | ||
*/ | ||
interpretResponse: function (responseObj, request) { | ||
responseObj = responseObj.body; | ||
|
@@ -629,7 +634,6 @@ export const spec = { | |
if (!responseObj || typeof responseObj !== 'object') { | ||
return []; | ||
} | ||
|
||
// Response from PBS Java openRTB | ||
if (responseObj.seatbid) { | ||
const responseErrors = deepAccess(responseObj, 'ext.errors.rubicon'); | ||
|
@@ -655,7 +659,7 @@ export const spec = { | |
return []; | ||
} | ||
|
||
return ads.reduce((bids, ad, i) => { | ||
let bids = ads.reduce((bids, ad, i) => { | ||
(ad.impression_id && lastImpId === ad.impression_id) ? multibid++ : lastImpId = ad.impression_id; | ||
|
||
if (ad.status !== 'ok') { | ||
|
@@ -716,6 +720,16 @@ export const spec = { | |
}, []).sort((adA, adB) => { | ||
return (adB.cpm || 0.0) - (adA.cpm || 0.0); | ||
}); | ||
|
||
let fledgeAuctionConfigs = responseObj.component_auction_config?.map(config => { | ||
return { config, bidId: config.bidId } | ||
}); | ||
|
||
if (fledgeAuctionConfigs) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While that would be better, it breaks some unit tests it's not worth fixing right now. I'll plan to deal with this when we aren't trying to get this out so quickly |
||
return { bids, fledgeAuctionConfigs }; | ||
} else { | ||
return bids; | ||
} | ||
}, | ||
getUserSyncs: function (syncOptions, responses, gdprConsent, uspConsent, gppConsent) { | ||
if (!hasSynced && syncOptions.iframeEnabled) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this
bidId
returned by AE have to match thebidId
prebid has for the bidRequest?Where is DV+ getting this
bidId
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. They're getting it from the fastlane param we pass in the adapter