Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent User Id Module: Use gppApplicableSections and gppString #10713

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

wi101
Copy link
Contributor

@wi101 wi101 commented Nov 10, 2023

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

LiveConnect added support for gpp.
In the LiveIntent UserId, forward the gppSections and gppString to set the LiveConnect gpp configuration.

Other information

@ChrisHuie
Copy link
Collaborator

@wi101 can you take out the package-lock change? We are a few versions ahead of the change now

@wi101
Copy link
Contributor Author

wi101 commented Nov 14, 2023

@ChrisHuie I updated the branch with master and ran npm install it fixed the version in master as well. Should I leave that change in package-lock ?

@ChrisHuie
Copy link
Collaborator

@ChrisHuie I updated the branch with master and ran npm install it fixed the version in master as well. Should I leave that change in package-lock ?

Yeah. This is fine :)

@@ -6,7 +6,7 @@
"packages": {
"": {
"name": "prebid.js",
"version": "8.21.0-pre",
"version": "8.24.0-pre",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this change

@patmmccann patmmccann merged commit 83390b9 into prebid:master Nov 14, 2023
4 checks passed
@patmmccann patmmccann changed the title Use gppApplicableSections and gppString In LiveIntent's Prebid User Id Module LiveIntent User Id Module: Use gppApplicableSections and gppString Nov 14, 2023
@wi101 wi101 deleted the v8-gpp-liveintent-userID branch November 14, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants