-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mediago Bid Adapter : add cookieSync and gdpr #10724
Merged
Merged
Changes from 52 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
d34c542
Mediago Bid Adapter:new adapter
dfea766
remove console
ba97c8a
change spec file to fix CircleCI
d96c1fc
change spec file to fix CircleCI
66bf6a0
change spec file
461cf79
Update mediagoBidAdapter.js
BaronJHYu 618809e
Update mediagoBidAdapter.js
d4e14f7
rerun CurcleCi
BaronJHYu da74779
update mediagoBidAdapter
801884b
Merge branch 'master' of github.com:BaronJHYu/Prebid.js
63b7cc5
Merge branch 'master' of github.com:prebid/Prebid.js into prebid-master
8e4199c
Merge branch 'prebid-master'
20353cb
Merge branch 'prebid:master' into master
BaronJHYu b52fd79
update discoveryBidAdapter
541cfed
Merge branch 'prebid:master' into master
BaronJHYu 9a55054
Discovery Bid Adapter : parameter updates
355d2b1
Mediago Bid Adapter : parameter updates
6fb0a02
Mediago Bid Adapter : code style format
68dcbd8
rerun circleci
bb2777c
rerun circleci
0ed9493
rerun circleci
d09cf94
rerun circleci
9e42186
Merge branch 'prebid:master' into master
BaronJHYu 28b5d2b
Update mediagoBidAdapter & discoveryBidAdapter:report eids to server
809dc71
Merge branch 'master' of github.com:BaronJHYu/Prebid.js
5c24963
Update mediagoBidAdapter & discoveryBidAdapter:report eids to server
e103260
update Mediago & Discovery BidAdapter:remove size filter
f7e7b2a
update Mediago & Discovery BidAdapter:code format
2b1d8c0
update Mediago & Discovery BidAdapter:code format
d3c8806
update Mediago & Discovery BidAdapter:add param in banner format
8451b08
Merge branch 'prebid:master' into master
BaronJHYu 32492f1
update mediago & discovery:first party data
455b843
Merge branch 'master' of github.com:BaronJHYu/Prebid.js
5d92500
update mediago & discovery:first party data
e897e9a
update mediago & discovery:first party data
409b599
Merge branch 'prebid:master' into master
BaronJHYu 5658450
fix(mediago & discovery): update param tagid
c6ad1c1
fix(mediago & discovery): update param tagid
041876b
Merge branch 'prebid:master' into master
BaronJHYu 5cfd1fd
Merge branch 'prebid:master' into master
BaronJHYu d5cb0fb
feat:add imp params for analysis
96eb09a
fix:add imp params for analysis
3833b90
code format
e2c81fb
test:add test data & test
98db061
format code
3c6de5b
rerun circleci
2d05d00
Merge branch 'prebid:master' into master
BaronJHYu 2d8cfc3
Merge branch 'prebid:master' into master
BaronJHYu cc1895d
feat: 1. add cookieSync 2. add gdpr
5d81f7e
code format
fca52d6
rerun circleci
ace0549
add gvlid
1847dcf
feat:add param 1.ppuid 2.content 3.cat 4.reqtime
e89124f
Merge branch 'prebid:master' into master
BaronJHYu 10f546a
fix: getUserSyncs param fixed
4377fc2
fix: getUserSyncs param fixed
486e88e
feat: add param 1. adUnitCode 2. referrer
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running this in simple testing, I'm getting this error.
mediagoBidAdapter.js:433 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'consentString')
at Object.getUserSyncs (mediagoBidAdapter.js:433:76)
at bidderFactory.js:512:22
at registerSyncs (bidderFactory.js:347:5)
at bidderFactory.js:265:11
at Object.runWithBidder (config.js:508:14)
at afterAllResponses (bidderFactory.js:263:9)
at perfMetrics.js:288:17
at utils.js:661:12
at bidderFactory.js:448:7
at runWithBidder (config.js:508:14)
I'm not setting up any of the gdpr things for this test, just a simple test in hello_world.html. I would assume you want this to function to work in this situation as well. I think you should be checking if these variables are set in this function. You can see the various ways people are checking for this in other adapters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reminding, i have fixed error.