identityLinkIdSystem: include gpp in 3p envelope retrieval #10745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smenzer Can you please do a review? |
smenzer
requested changes
Nov 20, 2023
| gppConsentDataStub.restore(); | ||
| }); | ||
|
|
||
| it('should NOT call the LiveRamp envelope endpoint if GPP applies but no consent string', function () { |
There was a problem hiding this comment.
this says that the endpoint should NOT be called, but below on line 155 it seems to say it IS called. can you clarify for me, please?
There was a problem hiding this comment.
Oh, we should change test description, so we should still call 3p endpoint if we do not have gpp consent string but we would just not attach to url that needs to be called. I will change description now.
There was a problem hiding this comment.
@smenzer can you please take a look? Tnx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identityLink - Liveramp
Type of change
Description of change
Add logic to get gpp consent string using Prebid consent management module and include gpp consent string and section id in 3p http request in order to get envelope.