Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insticator Bid Adaptor : add support for playerSize, plcmt, vastXML, & vastURL #10903

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 71 additions & 7 deletions modules/insticatorBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,42 @@ function buildBanner(bidRequest) {
}

function buildVideo(bidRequest) {
const w = deepAccess(bidRequest, 'mediaTypes.video.w');
const h = deepAccess(bidRequest, 'mediaTypes.video.h');
let w = deepAccess(bidRequest, 'mediaTypes.video.w');
let h = deepAccess(bidRequest, 'mediaTypes.video.h');
const mimes = deepAccess(bidRequest, 'mediaTypes.video.mimes');
const placement = deepAccess(bidRequest, 'mediaTypes.video.placement') || 3;
const plcmt = deepAccess(bidRequest, 'mediaTypes.video.plcmt') || undefined;
const playerSize = deepAccess(bidRequest, 'mediaTypes.video.playerSize');

if (!w && playerSize) {
if (Array.isArray(playerSize[0])) {
w = parseInt(playerSize[0][0], 10);
} else if (typeof playerSize[0] === 'number' && !isNaN(playerSize[0])) {
w = parseInt(playerSize[0], 10);
}
}
if (!h && playerSize) {
if (Array.isArray(playerSize[0])) {
h = parseInt(playerSize[0][1], 10);
} else if (typeof playerSize[1] === 'number' && !isNaN(playerSize[1])) {
h = parseInt(playerSize[1], 10);
}
}

return {
let videoObj = {
placement,
mimes,
w,
h,
}

if (plcmt) {
videoObj = {
...videoObj,
plcmt
}
}
return videoObj
}

function buildImpression(bidRequest) {
Expand Down Expand Up @@ -235,7 +260,11 @@ function buildBid(bid, bidderRequest) {
meta.advertiserDomains = bid.adomain
}

return {
let mediaType = 'banner';
if (bid.adm && bid.adm.includes('<VAST')) {
mediaType = 'video';
}
let bidResponse = {
requestId: bid.impid,
creativeId: bid.crid,
cpm: bid.price,
Expand All @@ -244,11 +273,22 @@ function buildBid(bid, bidderRequest) {
ttl: bid.exp || config.getConfig('insticator.bidTTL') || BID_TTL,
width: bid.w,
height: bid.h,
mediaType: 'banner',
mediaType: mediaType,
ad: bid.adm,
adUnitCode: originalBid.adUnitCode,
...(Object.keys(meta).length > 0 ? {meta} : {})
};

if (mediaType === 'video') {
bidResponse.vastXml = bid.adm;
}

// Inticator bid adaptor only returns `vastXml` for video bids. No VastUrl or videoCache.
if (!bidResponse.vastUrl && bidResponse.vastXml) {
bidResponse.vastUrl = 'data:text/xml;charset=utf-8;base64,' + window.btoa(bidResponse.vastXml.replace(/\\"/g, '"'));
}

return bidResponse;
}

function buildBidSet(seatbid, bidderRequest) {
Expand Down Expand Up @@ -315,9 +355,26 @@ function validateVideo(bid) {
return true;
}

let w = deepAccess(bid, 'mediaTypes.video.w');
let h = deepAccess(bid, 'mediaTypes.video.h');
const playerSize = deepAccess(bid, 'mediaTypes.video.playerSize');
if (!w && playerSize) {
if (Array.isArray(playerSize[0])) {
w = parseInt(playerSize[0][0], 10);
} else if (typeof playerSize[0] === 'number' && !isNaN(playerSize[0])) {
w = parseInt(playerSize[0], 10);
}
}
if (!h && playerSize) {
if (Array.isArray(playerSize[0])) {
h = parseInt(playerSize[0][1], 10);
} else if (typeof playerSize[1] === 'number' && !isNaN(playerSize[1])) {
h = parseInt(playerSize[1], 10);
}
}
const videoSize = [
deepAccess(bid, 'mediaTypes.video.w'),
deepAccess(bid, 'mediaTypes.video.h'),
w,
h,
];

if (
Expand All @@ -341,6 +398,13 @@ function validateVideo(bid) {
return false;
}

const plcmt = deepAccess(bid, 'mediaTypes.video.plcmt');

if (typeof plcmt !== 'undefined' && typeof plcmt !== 'number') {
logError('insticator: video plcmt is not a number');
return false;
}

return true;
}

Expand Down
120 changes: 120 additions & 0 deletions test/spec/modules/insticatorBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,43 @@ describe('InsticatorBidAdapter', function () {
}
})).to.be.false;
});

it('should return false if video plcmt is not a number', () => {
expect(spec.isBidRequestValid({
...bidRequest,
...{
mediaTypes: {
video: {
mimes: [
'video/mp4',
'video/mpeg',
],
w: 250,
h: 300,
plcmt: 'NaN',
},
}
}
})).to.be.false;
});

it('should return true if playerSize is present instead of w and h', () => {
expect(spec.isBidRequestValid({
...bidRequest,
...{
mediaTypes: {
video: {
mimes: [
'video/mp4',
'video/mpeg',
],
playerSize: [250, 300],
placement: 1,
},
}
}
})).to.be.true;
});
});

describe('buildRequests', function () {
Expand Down Expand Up @@ -570,4 +607,87 @@ describe('InsticatorBidAdapter', function () {
expect(spec.getUserSyncs({}, [response])).to.have.length(0);
})
});

describe('Response with video Instream', function () {
const bidRequestVid = {
method: 'POST',
url: 'https://ex.ingage.tech/v1/openrtb',
options: {
contentType: 'application/json',
withCredentials: true,
},
data: '',
bidderRequest: {
bidderRequestId: '22edbae2733bf6',
auctionId: '74f78609-a92d-4cf1-869f-1b244bbfb5d2',
timeout: 300,
bids: [
{
bidder: 'insticator',
params: {
adUnitId: '1a2b3c4d5e6f1a2b3c4d'
},
adUnitCode: 'adunit-code-1',
mediaTypes: {
video: {
mimes: [
'video/mp4',
'video/mpeg',
],
playerSize: [[250, 300]],
placement: 2,
plcmt: 2,
}
},
bidId: 'bid1',
}
]
}
};

const bidResponseVid = {
body: {
id: '22edbae2733bf6',
bidid: 'foo9876',
cur: 'USD',
seatbid: [
{
seat: 'some-dsp',
bid: [
{
ad: '<Vast></Vast>',
impid: 'bid1',
crid: 'crid1',
price: 0.5,
w: 300,
h: 250,
adm: '<VAST version="4.0"><Ad></Ad></VAST>',
exp: 60,
adomain: ['test1.com'],
ext: {
meta: {
test: 1
}
},
}
],
},
]
}
};
const bidRequestWithVideo = utils.deepClone(bidRequestVid);

it('should have related properties for video Instream', function() {
const serverResponseWithInstream = utils.deepClone(bidResponseVid);
serverResponseWithInstream.body.seatbid[0].bid[0].vastXml = '<VAST version="4.0"><Ad></Ad></VAST>';
serverResponseWithInstream.body.seatbid[0].bid[0].mediaType = 'video';
const bidResponse = spec.interpretResponse(serverResponseWithInstream, bidRequestWithVideo)[0];
expect(bidResponse).to.have.any.keys('mediaType', 'vastXml', 'vastUrl');
expect(bidResponse).to.have.property('mediaType', 'video');
expect(bidResponse.width).to.equal(300);
expect(bidResponse.height).to.equal(250);
expect(bidResponse).to.have.property('vastXml', '<VAST version="4.0"><Ad></Ad></VAST>');
expect(bidResponse.vastUrl).to.match(/^data:text\/xml;charset=utf-8;base64,[\w+/=]+$/)
});
})
});