Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consent Management : cleanup references to allowAuctionWithoutConsent #11129

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Consent Management : cleanup references to allowAuctionWithoutConsent #11129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions integrationExamples/gpt/gdpr_hello_world.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@
pbjs.setConfig({
consentManagement: {
cmpApi: 'iab',
timeout: 5000,
allowAuctionWithoutConsent: true
timeout: 5000
},
pubcid: {
enable: false
Expand Down
2 changes: 1 addition & 1 deletion modules/consentManagement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export function resetConsentData() {

/**
* A configuration function that initializes some module variables, as well as add a hook into the requestBids function
* @param {{cmp:string, timeout:number, allowAuctionWithoutConsent:boolean, defaultGdprScope:boolean}} config required; consentManagement module config settings; cmp (string), timeout (int), allowAuctionWithoutConsent (boolean)
* @param {{cmp:string, timeout:number, defaultGdprScope:boolean}} config required; consentManagement module config settings; cmp (string), timeout (int))
*/
export function setConsentConfig(config) {
// if `config.gdpr`, `config.usp` or `config.gpp` exist, assume new config format.
Expand Down
2 changes: 1 addition & 1 deletion modules/consentManagementGpp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ export function resetConsentData() {

/**
* A configuration function that initializes some module variables, as well as add a hook into the requestBids function
* @param {{cmp:string, timeout:number, allowAuctionWithoutConsent:boolean, defaultGdprScope:boolean}} config required; consentManagement module config settings; cmp (string), timeout (int), allowAuctionWithoutConsent (boolean)
* @param {{cmp:string, timeout:number, defaultGdprScope:boolean}} config required; consentManagement module config settings; cmp (string), timeout (int))
*/
export function setConsentConfig(config) {
config = config && config.gpp;
Expand Down
2 changes: 1 addition & 1 deletion modules/consentManagementUsp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export function resetConsentData() {

/**
* A configuration function that initializes some module variables, as well as add a hook into the requestBids function
* @param {object} config required; consentManagementUSP module config settings; usp (string), timeout (int), allowAuctionWithoutConsent (boolean)
* @param {object} config required; consentManagementUSP module config settings; usp (string), timeout (int)
*/
export function setConsentConfig(config) {
config = config && config.usp;
Expand Down
1 change: 0 additions & 1 deletion test/pages/consent_mgt_gdpr.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@
consentManagement: {
gdpr: {
cmpApi: 'static',
allowAuctionWithoutConsent: true,
consentData: {
getConsentData: {
'gdprApplies': true,
Expand Down
2 changes: 0 additions & 2 deletions test/spec/modules/gdprEnforcement_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ describe('gdpr enforcement', function () {
let staticConfig = {
cmpApi: 'static',
timeout: 7500,
allowAuctionWithoutConsent: false,
consentData: {
getTCData: {
'tcString': 'COuqj-POu90rDBcBkBENAZCgAPzAAAPAACiQFwwBAABAA1ADEAbQC4YAYAAgAxAG0A',
Expand Down Expand Up @@ -894,7 +893,6 @@ describe('gdpr enforcement', function () {
setEnforcementConfig({
gdpr: {
cmpApi: 'iab',
allowAuctionWithoutConsent: true,
timeout: 5000
}
});
Expand Down