JW Player RTD Module : populate content url, title and description #11178
Conversation
ChrisHuie
changed the title
| @@ -329,15 +353,30 @@ export function addOrtbSiteContent(ortb2, contentId, contentData) { | |||
| content.id = contentId; | |||
| } | |||
|
|
|||
| const currentData = content.data = content.data || []; | |||
| if (contentUrl) { | |||
| content.url = contentUrl; | |||
There was a problem hiding this comment.
Should this override what might be in content already?
There was a problem hiding this comment.
Yes! If a publisher has requested that we enrich the bid request for a given media, then they have determined that the bid request is specific to that media, therefore we should override existing data in that field.
Unfortunately the oRTB spec only has room for 1 content description, which is unrealistic given that multiple videos could be rendering simultaneously on the page.
There was a problem hiding this comment.
this feels concerning, let's discuss in committee
There was a problem hiding this comment.
@patmmccann and @dgirardi this has been address by adding configuration params
Co-authored-by: Demetrio Girardi <demetrio.girardi@proton.me>
Co-authored-by: Demetrio Girardi <demetrio.girardi@proton.me>
|
@patmmccann what does the "on hold" label mean ? Does it block this from getting merged; If so, how can we resolve? |
|
Yes this blocked from merging, it is a breaking change |
| @@ -329,15 +353,30 @@ export function addOrtbSiteContent(ortb2, contentId, contentData) { | |||
| content.id = contentId; | |||
| } | |||
|
|
|||
| const currentData = content.data = content.data || []; | |||
| if (contentUrl) { | |||
| content.url = contentUrl; | |||
There was a problem hiding this comment.
this feels concerning, let's discuss in committee
| @@ -71,15 +81,31 @@ export function fetchTargetingInformation(jwTargeting) { | |||
| }); | |||
| } | |||
|
|
|||
| export function setOverrides(params) { | |||
| // For backwards compatibility, default to always unless overridden by Publisher. | |||
| overrideContentId = sanitizeOverrideParam(params.overrideContentId, ENRICH_ALWAYS); | |||
There was a problem hiding this comment.
Assuming this should be updated for 9, do you have a way to track it - would a TODO comment be helpful?
|
@patmmccann can we remove the |
Type of change
Feature
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Description of change
Includes content url, title and description when enriching the
ortb.site.content.Other information
Docs PR: prebid/prebid.github.io#5190