Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubx.ai RTD Provider - Initial Release #11300

Merged
merged 28 commits into from
May 1, 2024
Merged

Conversation

pruthvimuga
Copy link
Contributor

@pruthvimuga pruthvimuga commented Apr 5, 2024

Type of change

  • feature

Description of change

  • Fetch RTD data to set dynamic floors from pubx.ai floors endpoint. This RTD module provides greater control over the dynamic floors returned from Pubx.ai and works well with Pubx.ai's flooring solutions.

Other information

@pruthvimuga pruthvimuga changed the title Pubx.ai Rtd Provider [Pubx.ai](https://pubx.ai/) RTD Provider - Initial Release Apr 9, 2024
@pruthvimuga pruthvimuga changed the title [Pubx.ai](https://pubx.ai/) RTD Provider - Initial Release Pubx.ai RTD Provider - Initial Release Apr 9, 2024
@pruthvimuga pruthvimuga marked this pull request as ready for review April 9, 2024 11:45
@ChrisHuie ChrisHuie self-requested a review April 9, 2024 14:28
@ChrisHuie ChrisHuie self-assigned this Apr 9, 2024
@ChrisHuie ChrisHuie requested review from Fawke and removed request for ChrisHuie April 15, 2024 14:08
@ChrisHuie ChrisHuie assigned Fawke and unassigned ChrisHuie Apr 15, 2024
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 51c63b6 into prebid:master May 1, 2024
4 checks passed
@pnhegde pnhegde deleted the pubx-rtd-module branch May 2, 2024 10:41
Ticki84 pushed a commit to criteo-forks/Prebid.js that referenced this pull request May 14, 2024
* Add pubx RTD module

* Add pubx RTD module documentation

* Add basic tests for pubx RTD module

* Fix the failing tests

* Added logic to fetch floors and set to auction

* Updated setDataToConfig to attach floors data to bidder requests object

* pubx rtd module:
* fetch floor rules
* timeout defaults
* floors config customizations
* pubx on/off from floors response

* move fetch floors to init and also wait for it before auction

* TESTS: update

* replace createFloorsDataForAuction to avoid circular dep - WIP

* reset default floors when no floor response is received

* TESTS: add test

* tag integration - fetch floors api events

* * Remove coonsole.log
* move __pubxFloorRulesPromise__ to window
* Remove unused var error

* TESTS: add getBidRequestData, refactor stubs

* TESTS: setFloorsApiStatus

* TESTS: add fetchFloorRules

* remove useRtd

* make endpoint potional and take pubxId form provider config

* TESTS: use xhr to fakeServer instead of sinon

* make default data optional

* update README

* TEST: update tests

* add integration example

* remove floorProvider from default config

* fix linting

* update readme.md

---------

Co-authored-by: Phaneendra Hegde <phaneendra@pubx.ai>
Co-authored-by: Phaneendra Hegde <pnhegde@users.noreply.github.com>
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request May 21, 2024
* Add pubx RTD module

* Add pubx RTD module documentation

* Add basic tests for pubx RTD module

* Fix the failing tests

* Added logic to fetch floors and set to auction

* Updated setDataToConfig to attach floors data to bidder requests object

* pubx rtd module:
* fetch floor rules
* timeout defaults
* floors config customizations
* pubx on/off from floors response

* move fetch floors to init and also wait for it before auction

* TESTS: update

* replace createFloorsDataForAuction to avoid circular dep - WIP

* reset default floors when no floor response is received

* TESTS: add test

* tag integration - fetch floors api events

* * Remove coonsole.log
* move __pubxFloorRulesPromise__ to window
* Remove unused var error

* TESTS: add getBidRequestData, refactor stubs

* TESTS: setFloorsApiStatus

* TESTS: add fetchFloorRules

* remove useRtd

* make endpoint potional and take pubxId form provider config

* TESTS: use xhr to fakeServer instead of sinon

* make default data optional

* update README

* TEST: update tests

* add integration example

* remove floorProvider from default config

* fix linting

* update readme.md

---------

Co-authored-by: Phaneendra Hegde <phaneendra@pubx.ai>
Co-authored-by: Phaneendra Hegde <pnhegde@users.noreply.github.com>
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* Add pubx RTD module

* Add pubx RTD module documentation

* Add basic tests for pubx RTD module

* Fix the failing tests

* Added logic to fetch floors and set to auction

* Updated setDataToConfig to attach floors data to bidder requests object

* pubx rtd module:
* fetch floor rules
* timeout defaults
* floors config customizations
* pubx on/off from floors response

* move fetch floors to init and also wait for it before auction

* TESTS: update

* replace createFloorsDataForAuction to avoid circular dep - WIP

* reset default floors when no floor response is received

* TESTS: add test

* tag integration - fetch floors api events

* * Remove coonsole.log
* move __pubxFloorRulesPromise__ to window
* Remove unused var error

* TESTS: add getBidRequestData, refactor stubs

* TESTS: setFloorsApiStatus

* TESTS: add fetchFloorRules

* remove useRtd

* make endpoint potional and take pubxId form provider config

* TESTS: use xhr to fakeServer instead of sinon

* make default data optional

* update README

* TEST: update tests

* add integration example

* remove floorProvider from default config

* fix linting

* update readme.md

---------

Co-authored-by: Phaneendra Hegde <phaneendra@pubx.ai>
Co-authored-by: Phaneendra Hegde <pnhegde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants