Alkimi Bid Adapter : add handling for user-sync URL and pass custom object with bid request #11326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
Sending no decode whole url options to true, to avoid errors while de…
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
|
Hi I am not sure why the e2etest is failing, Could you please check this and help on this failure? if it's possible could you please rerun the e2etest from your side? thanks. |
ChrisHuie
changed the title
Sometimes the e2e testing is flaky. Don't worry about it. |
|
Hello We are waiting for his change to be merged, Could you please check and approve it? Thanks. |
robertrmartinez
requested changes
Apr 18, 2024
| @@ -141,6 +152,24 @@ export const spec = { | |||
| return true; | |||
| } | |||
| return false; | |||
| }, | |||
|
|
|||
| getUserSyncs: function(syncOptions, serverResponses, gdprConsent) { | |||
There was a problem hiding this comment.
you are not passing along any of gdprConsent, uspConsent, gppConsent to your sync urls.
Just want to confirm this is intended.
There was a problem hiding this comment.
we resolve gdpr info on server
modules/alkimiBidAdapter.js
Outdated
| if (!serverBody || typeof serverBody !== 'object') return []; | ||
|
|
||
| const { iframeList } = serverBody; | ||
| if (!iframeList || typeof iframeList !== 'object') return []; |
There was a problem hiding this comment.
If iframeList is an object but not an array you may get an error below. Maybe change this to
if (!Array.isArray(iframeList)) return [];There was a problem hiding this comment.
@robertrmartinez Could you please check the latest changes and approve? Thanks.
|
Hello @robertrmartinez / @ChrisHuie Could you please check this change and approve it? We are completely blocked deliver this change. Thanks. |
robertrmartinez
approved these changes
Apr 25, 2024
Ticki84
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
May 14, 2024
…bject with bid request (prebid#11326) * Alkimi bid adapter * Alkimi bid adapter * Alkimi bid adapter * alkimi adapter * onBidWon change * sign utils * auction ID as bid request ID * unit test fixes * change maintainer info * Updated the ad unit params * features support added * transfer adUnitCode * transfer adUnitCode: test * AlkimiBidAdapter getFloor() using * ALK-504 Multi size ad slot support * ALK-504 Multi size ad slot support * Support new OpenRTB parameters * Support new oRTB2 parameters * remove pos parameter * Add gvl_id into Alkimi adapter * Insert keywords into bid-request param * Resolve AUCTION_PRICE macro on prebid-server for VAST ads * Added support for full page auction * Added custom user object * userParams in request object * Handling user-sync url, store user id and passing custom params * Renamed the full_page_auction to fpa * Updated the review comment --------- Co-authored-by: Alexander <32703851+pro-nsk@users.noreply.github.com> Co-authored-by: Alexander Bogdanov <akascheev@asteriosoft.com> Co-authored-by: Alexander Bogdanov <abogdanov@asteriosoft.com> Co-authored-by: motors <motors@live.ru> Co-authored-by: mihanikw2g <92710748+mihanikw2g@users.noreply.github.com> Co-authored-by: Nikulin Mikhail <mnikulin@asteriosoft.com> Co-authored-by: mik <mihanikw2g@gmail.com>
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
…bject with bid request (prebid#11326) * Alkimi bid adapter * Alkimi bid adapter * Alkimi bid adapter * alkimi adapter * onBidWon change * sign utils * auction ID as bid request ID * unit test fixes * change maintainer info * Updated the ad unit params * features support added * transfer adUnitCode * transfer adUnitCode: test * AlkimiBidAdapter getFloor() using * ALK-504 Multi size ad slot support * ALK-504 Multi size ad slot support * Support new OpenRTB parameters * Support new oRTB2 parameters * remove pos parameter * Add gvl_id into Alkimi adapter * Insert keywords into bid-request param * Resolve AUCTION_PRICE macro on prebid-server for VAST ads * Added support for full page auction * Added custom user object * userParams in request object * Handling user-sync url, store user id and passing custom params * Renamed the full_page_auction to fpa * Updated the review comment --------- Co-authored-by: Alexander <32703851+pro-nsk@users.noreply.github.com> Co-authored-by: Alexander Bogdanov <akascheev@asteriosoft.com> Co-authored-by: Alexander Bogdanov <abogdanov@asteriosoft.com> Co-authored-by: motors <motors@live.ru> Co-authored-by: mihanikw2g <92710748+mihanikw2g@users.noreply.github.com> Co-authored-by: Nikulin Mikhail <mnikulin@asteriosoft.com> Co-authored-by: mik <mihanikw2g@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Feature
[No] Does this change affect user-facing APIs or examples documented on http://prebid.org?
Description of change
Other information