PAAPI: emit addComponentAuction event #11341
Conversation
ETNOL
force-pushed
the
master
branch
2 times, most recently
from
602ec63
to
c85ad53
Compare
Component Auction Configs appear to be entirely contained within the PAAPI + fledgeForGPT modules. This event provides a way to access those configs from outside of those 2 modules.
| @@ -549,6 +549,7 @@ export const registerSyncInner = hook('async', function(spec, responses, gdprCon | |||
| }, 'registerSyncs') | |||
|
|
|||
| export const addComponentAuction = hook('sync', (request, fledgeAuctionConfig) => { | |||
| events.emit(CONSTANTS.EVENTS.ADD_COMPONENT_AUCTION, request, fledgeAuctionConfig); | |||
There was a problem hiding this comment.
With #11277 , this is being expanded (and renamed) to also support adding single buyers.
There's also the fact that if the paapi module is not installed, this data is just dropped - I'm not sure the event makes sense here (the component auction is not really "added").
There was a problem hiding this comment.
Does the need make sense? Prebid currently will event for things like new BidRequests or BidResponses, but I can't find any event that includes the fledgeAuctionConfigs. The paapi.js module doesn't seem ideal either, since a fledgeAuctionConfig can be returned from a BidAdapter without that module included.
Namespace-wise, I just followed with the name of the hook. If one name doesn't make sense, not sure if the other does either, right?
There was a problem hiding this comment.
bidRequested and bidResponse are only fired when the action is "final" (if they fail validation or are rejected they may trigger other events, but not those). Without the paapi module adapters would typically not get the ae signal and presumably they wouldn't have a reason to return auction configs.
It doesn't translate perfectly, but IMO it would be more consistent to fire something like componentAuction from the paapi module at the time all processing is done (they have first party data added) and they're "locked in".
If there's a need to know when configs are dropped I would make it a separate event - maybe unusedComponentAuction?
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Component Auction Configs appear to be entirely contained within the
PAAPI + fledgeForGPT modules. This event provides a way to access
those configs from outside of those 2 modules.
Other information