Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnite Analytics: auction index + small cleanup #11345

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

robertrmartinez
Copy link
Collaborator

Type of change

  • Other

Description of change

  • Move all globally declared vars grouped together
  • Add auctionIndex metric

Copy link
Contributor

@apukh-magnite apukh-magnite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChrisHuie ChrisHuie self-assigned this Apr 16, 2024
@ChrisHuie ChrisHuie changed the title Magnite Analytics: Auction Index + Small cleanup Magnite Analytics: auction index + small cleanup Apr 16, 2024
@patmmccann patmmccann merged commit 8748f8f into master Apr 16, 2024
4 checks passed
@patmmccann patmmccann deleted the mgniAnalytics-smallAdditions branch April 16, 2024 13:53
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Apr 25, 2024
* move globals up + add auctionIndex

* add / update tests
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* move globals up + add auctionIndex

* add / update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants